>From 84bf2cd161b477bbe223eee3b72041401adc1062 Mon Sep 17 00:00:00 2001 From: raingloom Date: Sat, 5 Sep 2020 17:00:05 +0200 Subject: [PATCH 2/2] gnu: Update picard to 2.4.4 with patch. * gnu/packages/music.scm (picard): Update to 2.4.4. [native-inputs]: Add python-dateutil. [source]: Add temporary patch to fix failing test due to missing "." in temporary filename. * gnu/packages/patches/picard-fix-id3-rename-test.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 1 + gnu/packages/music.scm | 8 +++++--- gnu/packages/patches/picard-fix-id3-rename-test.patch | 11 +++++++++++ 3 files changed, 17 insertions(+), 3 deletions(-) create mode 100644 gnu/packages/patches/picard-fix-id3-rename-test.patch diff --git a/gnu/local.mk b/gnu/local.mk index 3b97b8fdf3..67c67a8bc8 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1417,6 +1417,7 @@ dist_patch_DATA = \ %D%/packages/patches/perl-module-pluggable-search.patch \ %D%/packages/patches/perl-reproducible-build-date.patch \ %D%/packages/patches/perl-www-curl-remove-symbol.patch \ + %D%/packages/patches/picard-fix-id3-rename-test.patch \ %D%/packages/patches/picprog-non-intel-support.patch \ %D%/packages/patches/pidgin-add-search-path.patch \ %D%/packages/patches/pidgin-libnm.patch \ diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index bbbb0d6819..a4cd1a9daa 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -2807,7 +2807,7 @@ event-based scripts for scrobbling, notifications, etc.") (define-public picard (package (name "picard") - (version "2.1.3") + (version "2.4.4") (source (origin (method url-fetch) (uri (string-append @@ -2815,7 +2815,8 @@ event-based scripts for scrobbling, notifications, etc.") "picard/picard-" version ".tar.gz")) (sha256 (base32 - "19w5k3bf4886gdycxjds9nkjvir0gwy2r5cqkz0lbls4ikk4y14f")))) + "1c5l7i43jaj3s4wklc0cba6nn2x9cmpcggk4q4h9m1bci2xilsiy")) + (patches (search-patches "picard-fix-id3-rename-test.patch")))) (build-system python-build-system) (arguments '(#:use-setuptools? #f @@ -2834,7 +2835,8 @@ event-based scripts for scrobbling, notifications, etc.") (assoc-ref inputs "chromaprint") "/bin/fpcalc"))) #t))))) (native-inputs - `(("gettext" ,gettext-minimal))) + `(("gettext" ,gettext-minimal) + ("python-dateutil" ,python-dateutil))) (inputs `(("chromaprint" ,chromaprint) ("python-discid" ,python-discid) diff --git a/gnu/packages/patches/picard-fix-id3-rename-test.patch b/gnu/packages/patches/picard-fix-id3-rename-test.patch new file mode 100644 index 0000000000..3c4fa63c84 --- /dev/null +++ b/gnu/packages/patches/picard-fix-id3-rename-test.patch @@ -0,0 +1,11 @@ +Index: b/test/formats/test_id3.py +=================================================================== +--- a/test/formats/test_id3.py ++++ b/test/formats/test_id3.py +@@ -266,5 +266,5 @@ + def test_rename_txxx_tags(self): + file_path = os.path.join('test', 'data', 'test-id3-rename-tags.mp3') +- filename = self.copy_file_tmp(file_path, 'mp3') ++ filename = self.copy_file_tmp(file_path, '.mp3') + raw_metadata = load_raw(filename) + self.assertIn('TXXX:Artists', raw_metadata) -- 2.28.0