--- Begin Message ---
Subject: |
[PATCH] doc: Add item to "Submitting Patches" section. |
Date: |
Mon, 12 Oct 2020 10:20:03 +0200 |
* doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
--base'.
---
doc/contributing.texi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index af3601442e..5ea3cb1899 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package
definition,
please run through this check list:
@enumerate
+@cindex @code{git format-patch}
+@cindex @code{git-format-patch}
+@item
+We recommend to use the command @code{git format-patch --base} to
+include the commit where your patch applies.
+
@item
If the authors of the packaged software provide a cryptographic
signature for the release tarball, make an effort to verify the
base-commit: e746d30ec15852ec50e4247ea0a07ab2a9a69aa8
--
2.28.0
--- End Message ---
--- Begin Message ---
Subject: |
Re: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section. |
Date: |
Sat, 24 Oct 2020 12:01:51 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi,
zimoun <zimon.toutoune@gmail.com> writes:
> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> --base'.
> ---
> doc/contributing.texi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a
> package definition,
> please run through this check list:
>
> @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.
“git format-patch” already mentioned in the documentation in the first
paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
Do I miss something? Fill free to reopen the issue ;-)
Oleg.
signature.asc
Description: PGP signature
--- End Message ---