Re: [Duplicity-talk] Duplicity 1.0.1 Released

On Wed, Oct 5, 2022 at 10:48 AM Scott Hannahs <sth@p-hall.net> wrote:

Scott runs an ancient version of MacOS, although nothing has changed that would introduce that warning.

No, no. My old ancient 2009 hardware died… :-( I replaced it with a new machine a few months ago.

This is running the latest and greatest MacOS (Monterey), but I did update Xcode since compiling the last 0.8.X version of duplicity which passed tests I believe.

Each build starts with a clean sandbox and empty “testing” directory. The entire build and testing is built in ""/opt/sw/src/fink.build/duplicity-1.0.1-1/“ and if all builds successfully then a debian dpkg is built and then optionally installed on the working system. This is using the “fink” package manager for OS X which is something I am trying to support for duplicity.

I think the line:
ImportError: cannot import name '_librsync' from ‘duplicity'

is the smoking gun. I agree that the compiler warning is a red herring unless it prevents building the correct dynamic library.

-Scott

On Oct 5, 2022, at 11:08, Kenneth Loafman <kenneth@loafman.com> wrote:

Hi Scott,

It's probably the testing/testfiles directory hanging around. do "$ sudo rm -rf testing/testfiles" to get rid of it and the tests should run.

If that doesn't work, ZIP a full log of the tests and send it to me.

@ede, the compile warning is a red herring. Scott runs an ancient version of MacOS, although nothing has changed that would introduce that warning.

@scott, I test on current Mac and Linux before committing, so all the tests pass except some that are skipped, not failed, mostly due to Mac's funky unicode handling.

...Ken

On Wed, Oct 5, 2022 at 9:31 AM Scott Hannahs via Duplicity-talk <duplicity-talk@nongnu.org> wrote:
Well, even if I can get rid of the warning, _librsync doesn’t seem to load, though it has in the past. Do I need to set a PYTHONPATH here or something to run the tests?

It does fail on "from . import _librsync”. It is trying to import that from the librsync.py which implies that it is not building the .so file but I see the .so file in the sandbox directory.

-Scott

E duplicity.errors.BackendException: Error running 'tahoe cp /var/folders/6b/85yg9bp94rv55dzbdp78thp40000kr/T/testfiles/local var:folders/6b/85yg9bp94rv55dzbdp78thp40000kr/T/testfiles/output/file-a': return
ed 1, with output:
E
E Traceback (most recent call last):
E File "/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/testing/overrides/bin/tahoe", line 11, in <module>
E from testing import _runtest_dir
E File "/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/testing/__init__.py", line 33, in <module>
E from duplicity import backend
E File "/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/duplicity/backend.py", line 44, in <module>
E from duplicity import dup_temp
E File "/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/duplicity/dup_temp.py", line 34, in <module>
E from duplicity import path
E File "/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/duplicity/path.py", line 49, in <module>
E from duplicity import librsync
E File "/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/duplicity/librsync.py", line 36, in <module>
E from . import _librsync
E ImportError: cannot import name '_librsync' from 'duplicity' (/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/duplicity/__init__.py)

/opt/sw/src/fink.build/duplicity-1.0.1-1/duplicity-1.0.1/duplicity/backend.py:527: BackendException

On Oct 5, 2022, at 7:35 AM, edgar.soldin--- via Duplicity-talk <duplicity-talk@nongnu.org> wrote:

not sure that this is the reason, but apparently there is a compiler flag "-Wl,-w" that get's rid of the warning
https://issues.guix.gnu.org/issue/57849

..ede

On 05.10.2022 04:27, Scott Hannahs via Duplicity-talk wrote:
In building version 1.0.0 or 1.0.1 I get a lot of errors running the tests with tox.
testing/unit/test_backend_instance.py ..............................FF.. [ 10%]
..
testing/functional/test_final.py FFFFFFFFFFFFFFFFFFFFFFFFFFF     [ 77%]
testing/functional/test_log.py F     [ 77%]
testing/functional/test_rdiffdir.py F   [ 77%]
testing/functional/test_replicate.py FFF     [ 78%]
testing/functional/test_restart.py FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF   [ 86%]
testing/functional/test_selection.py .FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF [ 94%]
FFFFssFFFFFFFssss   [ 98%]
testing/functional/test_verify.py FFFFFFFF     [100%]
I am not an expert on tox, but something is very different. This used to pass most of the tests (all but 4). It is being built and tested in a sandbox directory before installing. But tox is supposed to take care of all that.
The system builds _librsync.cpython-38-darwin.so as a library. But in building the library gcc gives a warning:
"ld: warning: -undefined dynamic_lookup may not work with chained fixups"
I have no ideas what that means, this is using the gcc from Apple Developer tools version 14.0.1. Is there some flag in newer gcc that needs to be adjusted?
-Scott
On Oct 4, 2022, at 12:07 PM, Kenneth Loafman via Duplicity-talk <duplicity-talk@nongnu.org <mailto:duplicity-talk@nongnu.org>> wrote:

You can see the full details of the changes in GitLab <https://gitlab.com/duplicity/duplicity/-/milestones/14#tab-issues> and Launchpad <https://launchpad.net/duplicity/+milestone/1.0.1> milestone pages and CHANGELOG <https://duplicity.gitlab.io/duplicity-web/vers1/CHANGELOG.html>.

_______________________________________________
Duplicity-talk mailing list
Duplicity-talk@nongnu.org
https://lists.nongnu.org/mailman/listinfo/duplicity-talk

From:	Kenneth Loafman
Subject:	Re: [Duplicity-talk] Duplicity 1.0.1 Released
Date:	Wed, 5 Oct 2022 10:54:57 -0500