Re: [PATCH 2/4] dmioem: Update HPE OEM Type 233

[Jean Delvare]

On Wed, 17 Apr 2024 10:22:55 -0600, Jerry Hoemann wrote:
> New field: Device Path String.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
>  dmioem.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/dmioem.c b/dmioem.c
> index 533a03a..71bd019 100644
> --- a/dmioem.c
> +++ b/dmioem.c
> @@ -1246,6 +1246,7 @@ static int dmi_decode_hp(const struct dmi_header *h)
>                        *  0x07  | Dev No | BYTE  | PCI Device/Function No
>                        *  0x08  |   MAC  | 32B   | MAC addr padded w/ 0s
>                        *  0x28  | Port No| BYTE  | Each NIC maps to a Port
> +                      *  0x29  | DevPath| STRING| UEFI Device Path of 
> network port.
>                        */
>                       pr_handle_name("%s BIOS PXE NIC PCI and MAC 
> Information",
>                                      company);
> @@ -1256,6 +1257,8 @@ static int dmi_decode_hp(const struct dmi_header *h)
>                       nic = h->length > 0x28 ? data[0x28] : 0xFF;
>                       dmi_print_hp_net_iface_rec(nic, data[0x06], data[0x07],
>                                                  &data[0x08]);
> +                     if (h->length < 0x2A) break;
> +                     pr_attr("UEFI Dev Path", "%s", dmi_string(h, 
> data[0x29]));

I changed "Dev Path" to "Device Path" for clarity and consistency with
types 203 and 238.

>                       break;
>  
>               case 236:

Applied, thanks.

-- 
Jean Delvare
SUSE L3 Support