[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] dmioem: HPE OEM Updates
From: |
Jean Delvare |
Subject: |
Re: [PATCH 0/6] dmioem: HPE OEM Updates |
Date: |
Fri, 7 Apr 2023 16:49:25 +0200 |
On Fri, 07 Apr 2023 15:15:15 +0200, Petter Reinholdtsen wrote:
> [Jean Delvare]
> > I can't see any indentation issue with these patches. Can you
> > elaborate?
>
> The existing code seem to use \t\t<space>, while the new code used
> \t\t. No idea what is wanted nor why the existing code showed up with
> the extra space, but thought it best to ask.
There's a leading space on lines which contain a multi-line C comment
(except the first). That's pretty much an industry standard, to align
the stars and make the comment easier to read.
There are also leading spaces added for alignment purposes on
multi-line conditionals. Other than this, the code is only aligned
using tabs, and Jerry's patches are OK in that respect.
--
Jean Delvare
SUSE L3 Support
- Re: [PATCH 6/6] dmioem: Update HPE OEM Record 216, (continued)
- [PATCH 5/6] dmioem: Update HPE OEM Record 238, Jerry Hoemann, 2023/04/06
- [PATCH 2/6] dmioem: Update HPE OEM Record 221, Jerry Hoemann, 2023/04/06
- [PATCH 1/6] dmioem: Update HPE OEM Record 203, Jerry Hoemann, 2023/04/06
- [PATCH 3/6] dmioem: Update HPE OEM Record 212, Jerry Hoemann, 2023/04/06
- Re: [PATCH 0/6] dmioem: HPE OEM Updates, Petter Reinholdtsen, 2023/04/07