Re: [PATCH 2/6] dmioem: Update HPE OEM Record 221

[Jean Delvare]

On Thu,  6 Apr 2023 17:38:56 -0600, Jerry Hoemann wrote:
> Record type depricated for Gen8.  If record number reused in future,

Spelling: deprecated.

> it will have a different decoding.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
>  dmioem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dmioem.c b/dmioem.c
> index 46c1142..3ada0cb 100644
> --- a/dmioem.c
> +++ b/dmioem.c
> @@ -943,6 +943,7 @@ static int dmi_decode_hp(const struct dmi_header *h)
>                        *
>                        * Type 221: is deprecated in the latest docs
>                        */
> +                     if ((gen >= G8) && h->type == 221) return 0;

Innermost parentheses are not needed.

No need to resubmit.

>                       pr_handle_name("%s %s", company, h->type == 221 ?
>                                      "BIOS iSCSI NIC PCI and MAC Information" 
> :
>                                      "BIOS PXE NIC PCI and MAC Information");


-- 
Jean Delvare
SUSE L3 Support