Re: [dmidecode] [PATCH v2 0/4] dmidecode: Decode HPE OEM record 236.

[Erwan Velu]

Thanks Jerry for making these commits which are way better than mine.
I cross my fingers firmly to get new OEM types committed soon.


Le lun. 30 nov. 2020 à 05:09, Jerry Hoemann <jerry.hoemann@hpe.com> a
écrit :

> Decode HPE OEM record 236: ProLiant HDD Backplane.
>
> Generally when HPE updates an OEM record, it adds new fields to the end
> of the record and updates the record length to reflect the fields added.
> This makes explicit checking of record version unnecessary as the length
> field implicitly encodes it.
>
> However, sometimes records are changed in a non-backward compatible way
> as a field gets redefined from one version to the next.  OEM 236 is such
> an example.
>
> Going forward, we believe the likelihood of non-backwards compatible
> changes will increase.
>
> The approach taken in this series is to use the Type 1 "Product Name"
> in addition to the "Manufacturer" to determine the Generation and
> hence revision of OEM record to use in decoding records that have
> non-backwards compatible changes.
>
> Note: This patch series does not address the ordering issue of OEM
>       records.  So OEM records that appear before Type 1 records
>       will not be decoded.
>
> patch 1: Sort OEM records in dmi_decode_hp
> patch 2: Some OEM records require Product Name
> patch 3: Use product name to determine Generation
> patch 4: Decode HPE OEM record 236
>
> Thanks to Erwan Velu <erwanaliasr1@gmail.com> who did the initial
> version of patch 4.
>
> === Changes in version 2 ===
>
> patch 1: Updated Submit comment
> patch 2: None, as maintainer plans to address separately.
> patch 3: Applied review comments.
> patch 4: Applied review comments.
>
>
>
>
> Jerry Hoemann (4):
>   dmioem: Sort OEM records in dmi_decode_hp
>   dmidecode: Some OEM records require Product Name
>   dmioem: Use product name to determine Generation.
>   dmioem: Decode HPE OEM record 236
>
>  dmidecode.c |   4 +-
>  dmioem.c    | 130 ++++++++++++++++++++++++++++++++++++++++------------
>  dmioem.h    |   2 +-
>  3 files changed, 103 insertions(+), 33 deletions(-)
>
> --
> 2.27.0
>
>