[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dmidecode] [PATCH] dmidecode: Add enumerated values from SMBIOS 3.3
|
From: |
Jean Delvare |
|
Subject: |
Re: [dmidecode] [PATCH] dmidecode: Add enumerated values from SMBIOS 3.3.0 |
|
Date: |
Fri, 18 Oct 2019 17:34:47 +0200 |
On Thu, 2019-10-17 at 16:25 -0600, Jerry Hoemann wrote:
> On Wed, Oct 16, 2019 at 03:35:04PM +0200, Jean Delvare wrote:
> > Add all the enumerated values from the SMBIOS 3.3.0 specification
> > update that was released last month.
> >
> > Signed-off-by: Jean Delvare <address@hidden>
> > ---
> > Support for new structure type 44 still needs to be implemented for
> > full SMBIOS 3.3.0 support.
> >
> > dmidecode.c | 44 +++++++++++++++++++++++++++++++++++---------
> > 1 file changed, 35 insertions(+), 9 deletions(-)
>
> These changes all look good to me.
Thanks for the review.
> Quesiton: do you derive changes in the SPEC by diffing the pdf,
> or by reviewing the "ANNEX C: Change log", or something else?
I review the list of changes in the annex.
--
Jean Delvare
SUSE L3 Support