Re: [Dazuko-devel] Dazuko-PHP 0.42 released

[John Ogness]

address@hidden wrote:
> Today, I have released dazuko 0.42.
>
> Hey John, try out this one ;-)

Hi,

I was able to get your PHP module to work, however I had to make some 
changes (see the included patch). Using this patch I was able to get it 
working on GNU/Linux and FreeBSD. It was not easy. You need to have 
pretty new versions of PHP and the other conf/make utilities. I had to 
download and install:

autoconf-2.59
automake-1.9
libtool-1.5.10
m4-1.4.2
php-5.0.2

It is also important that php.ini is correctly set up. Using 
"php.ini-recommended" doesn't work. You have to use "php.ini-dist". I am 
not a PHP person, so I do not know what is in "php.ini-recommended" that 
does not allow it to work.

The README describes "PHP embedded" but I have no idea where the 
"buildconf" script comes from. ?? Perhaps PHP embedded developers know 
more about this?

The description of "PHP extension" worked as long as you have recent 
development tools (listed above). I would recommend not mentioning using 
the "--with-dazuko=/path/to/dazuko-src" parameter since it causes 
problems. This is because Dazuko uses "library" and UNIX uses "lib". I 
think it is enough to tell people to copy the "libdazuko.a" und 
"dazukoio.h" files to "lib" and "include" respectively. Then there 
should be no problems (note: the supplied patch is also required).

I would like to see the README expanded to talk about the requirements 
(PHP5, etc) and use more details/examples when explaining how to set 
things up. It would also be nice if the example programs matched the C, 
Java, Perl, and Python versions (for arguments and output).

If you would be willing to make these changes, I would love to get your 
PHP version into the 2.0.5 version.

John Ogness

--
Dazuko Maintainer

--- dazuko.c    Tue Oct  5 18:31:50 2004
+++ ../dazuko-0.42-fixed/dazuko.c       Sun Oct 24 17:52:51 2004
@@ -221,6 +221,7 @@
 {
        zval                    *r_id;
        struct dazuko_event     *event;
+       struct dazuko_access    *acc;
        
        if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r", &r_id) == 
FAILURE) {
                return;
@@ -228,7 +229,7 @@
        
        ZEND_FETCH_RESOURCE(event, struct dazuko_event *, &r_id, -1, 
le_dazuko_result, le_dazuko_obj);
        
-       struct dazuko_access *acc = event->acc;
+       acc = event->acc;
        
        if (acc->set_event) {
                array_init(return_value);
@@ -513,6 +514,7 @@
        zval                    *r_id;
        struct dazuko_event     *event;
        long                    deny_access;
+       struct dazuko_access    *acc;
        
        if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rl", &r_id, 
&deny_access) == FAILURE) {
                return;
@@ -520,7 +522,7 @@
        
        ZEND_FETCH_RESOURCE(event, struct dazuko_event *, &r_id, -1, 
le_dazuko_result, le_dazuko_obj);
        
-       struct dazuko_access *acc = event->acc;
+       acc = event->acc;
        
        if (deny_access == DAZUKO_DENY) {
                acc->deny = DAZUKO_DENY;
@@ -726,6 +728,7 @@
        struct dazuko_event     *event;
        struct dazuko_resource  *f;
        long                    deny_access;
+       struct dazuko_access    *acc;
        
        if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rrl", &t_id, 
&r_id, &deny_access) == FAILURE) {
                return;
@@ -734,7 +737,7 @@
        ZEND_FETCH_RESOURCE(f, struct dazuko_resource *, &t_id, -1, 
le_dazuko_name, le_dazuko);
        ZEND_FETCH_RESOURCE(event, struct dazuko_event *, &r_id, -1, 
le_dazuko_result, le_dazuko_obj);
        
-       struct dazuko_access *acc = event->acc;
+       acc = event->acc;
        
        if (deny_access == DAZUKO_DENY) {
                acc->deny = DAZUKO_DENY;
--- config.m4   Tue Oct  5 18:02:36 2004
+++ ../dazuko-0.42-fixed/config.m4      Sun Oct 24 18:05:31 2004
@@ -36,12 +36,12 @@
 
   PHP_CHECK_LIBRARY($LIBNAME,$LIBSYMBOL,
   [
-    PHP_ADD_LIBRARY_WITH_PATH($LIBNAME, $DAZUKO_DIR/library, 
DAZUKO_SHARED_LIBADD)
+    PHP_ADD_LIBRARY_WITH_PATH($LIBNAME, $DAZUKO_DIR/../lib, 
DAZUKO_SHARED_LIBADD)
     AC_DEFINE(HAVE_DAZUKOLIB,1,[ ])
   ],[
     AC_MSG_ERROR([wrong dazuko lib version or lib not found])
   ],[
-    -L$DAZUKO_DIR/lib -lm -ldl
+    -L$DAZUKO_DIR/../lib -lm
   ])
   
   PHP_SUBST(DAZUKO_SHARED_LIBADD)