Re: Fwd: Bug#1015273: coreutils: rm -d doesn't try to remove unreadable directories, lies in error message, with *fails to prompt* with -i

[Jim Meyering]

On Tue, Feb 21, 2023 at 4:45 AM Pádraig Brady <P@draigbrady.com> wrote:
> On 21/02/2023 02:59, Jim Meyering wrote:
...
> > Thank you for the bug report.
> > I've attached a patch that fixes those bugs.
>
> lgtm
> modulo the commit summary line should start with rm: not rm ...
> Do you have git hooks disabled?

Thanks for the speedy review. I did indeed. Fixed that, inserted a
colon, and pushed.

BTW, when I pulled latest, I see (but haven't investigated) a new
build failure using this recent gcc:
gcc version 13.0.1 20230219 (experimental) (GCC)

In function 'lseek_copy',
    inlined from 'copy_reg' at src/copy.c:1501:16,
    inlined from 'copy_internal' at src/copy.c:2961:13:
src/copy.c:485:23: error: 'scan_inference.ext_start' may be used
uninitialized [-Werror=maybe-uninitialized]
  485 |       off_t ext_end = lseek (src_fd, ext_start, SEEK_HOLE);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/copy.c: In function 'copy_internal':
src/copy.c:1165:24: note: 'scan_inference.ext_start' was declared here
 1165 |   union scan_inference scan_inference;
      |                        ^~~~~~~~~~~~~~