[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] config.sub: add LLVM-libc support
From: |
Adam Joseph |
Subject: |
Re: [PATCH 1/2] config.sub: add LLVM-libc support |
Date: |
Thu, 26 Oct 2023 14:34:56 -0700 |
Quoting Alfred Persson Forsberg (2023-10-19 11:55:40)
> * config.sub (*-linux-llvm): Recognize.
> * doc/config.sub.1: Regenerate.
> * testsuite/config-sub.data: Add x86_64-linux-llvm.
Looks good to me; however, one question. I assume this triple covers llvm-libc
fullbuild mode:
https://libc.llvm.org/fullbuild_mode.html#fullbuild-mode
Does it also include overlay mode?
https://libc.llvm.org/overlay_mode.html#overlay-mode
If it includes overlay mode, how do we distinguish between the different
"underlying" libcs? Do we need to?
My suggestion would be to state that this triple covers only the fullbuild
version, and to update the config.guess logic so it is not triggered by
overlay-mode llvm-libc. That's the conservative approach; it lets us defer
deciding how to deal with overlay mode until later.
- a