[patch #1844] [Patch #1844] RMIC patch

[noreply]

Patch #1844 has been updated. 

Project: 
Category: None
Status: Closed
Summary: RMIC patch

Follow-Ups:

Date: Fri 08/29/03 at 23:29
By: mark

Comment:
Thanks. Applied with a few formatting fixes, and updated all copyright year 
notices. (But some of the files - RMIC.java - already used wrong indentation 
and I left those as is.) Also updated the Makefile.am EXTRA_DIST entry. Subtly 
changed the ChangeLog entry as follows to indicate every change entry with a 
':' separator and start each sentence with a capital letter:



2003-08-29  Dalibor Topic  <address@hidden>

 

        * gnu/java/rmi/rmic/Compile_gcj.java (COMPILER_ARGS): New private

        constant.

        (computeArguments): use computeTypicalArguments.

 

        * gnu/java/rmi/rmic/Makefile.am (EXTRA_DIST): Add Compile_kjc.java,

        Compile_jikes.java and RMICException.java.

        * gnu/java/rmi/rmic/Compile_kjc.java: New file.

        * gnu/java/rmi/rmic/Compile_jikes.java: Likewise.

        * gnu/java/rmi/rmic/RMICException.java: Likewise.

  

        * gnu/java/rmi/rmic/Compiler.java (getDestination): New method.

  

        * gnu/java/rmi/rmic/CompilerProcess.java: Import java.io.InputStream.

        (computeTypicalArguments): New method.

        (compile): Print compiler output to System.out. Collect compiler

        error output and use it in exception message.

  

        * gnu/java/rmi/rmic/RMIC.java: Import java.util.Set.

        (destination): Initialize to null.

        (run): Replace file separator with '.' when processing class.

        (processClass): Replace '.' with file separator when compiling

        classes.

        (findClass): Use SystemClassLoader to load class.

        (generateStub): Use full class name for generated stub, that puts

        it in right path.  Replace '.' with file separator when generating

        stub file name. Write just the stub class name without package

        information as class name, and constructor name. Write only

        interface names for interfaces extending java.rmi.Remote as

        implemented.

        (generateSkel): Use full class name for generated skel, that puts

        it in right path.  Replace '.' with file separator when generating

        stub file name. Write just the stub class name without package

        information as class name.



The System.out/err collection can probably be improved a bit by reading bigger 
buffers and not single chars, but I didn't change this.



I was not sure the exception should be that the comment "FIXME: wrong exception 
class" points out. Since this was already in the original code I left it as is.



We might want to move the rmic tool to cp-tools at some time to have a common 
cvs tree with all the classpath tools.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.gnu.org/patch/?func=detailpatch&patch_id=1844&group_id=85

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/