[Chicken-users] Last two snapshots (3.3.5 and 3.3.6) are broken

[Aleksej Saushev]

  Hello!

Last two snapshots are broken, the build with host PCRE fails,
currently I've patched it (see the patch below), but I want to
raise the issue once again.

Please, don't build against bundled pcre, at least for BSD's,
the policy on all of them (known to me) is to build against
common libraries, not package-internal ones.

It would be nice, if bundled pcre was dropped at all, this will
ease maintanance and testing, and prevent you from making such
stupid mistakes.


Appendices.

Fix PCRE references.

--- rules.make.orig     2008-07-30 08:00:05.000000000 +0400
+++ rules.make  2008-08-01 17:40:49.000000000 +0400
@@ -135,7 +135,11 @@
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) 
$(C_COMPILER_SHARED_OPTIONS) \
          $(C_COMPILER_BUILD_RUNTIME_OPTIONS) $< $(C_COMPILER_OUTPUT)
+ifeq ($(USE_HOST_PCRE),)
 regex$(O): regex.c chicken.h $(CHICKEN_CONFIG_H) $(PCRE_DIR)/pcre.h
+else
+regex$(O): regex.c chicken.h $(CHICKEN_CONFIG_H)
+endif
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(PCRE_INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) 
$(C_COMPILER_SHARED_OPTIONS) \
          $(C_COMPILER_BUILD_RUNTIME_OPTIONS) $(C_COMPILER_PCRE_OPTIONS) $< 
$(C_COMPILER_OUTPUT)
@@ -220,7 +224,11 @@
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) 
$(C_COMPILER_SHARED_OPTIONS) \
          $(C_COMPILER_BUILD_UNSAFE_RUNTIME_OPTIONS) $< $(C_COMPILER_OUTPUT)
+ifeq ($(USE_HOST_PCRE),)
 uregex$(O): uregex.c chicken.h $(CHICKEN_CONFIG_H) $(PCRE_DIR)/pcre.h
+else
+uregex$(O): uregex.c chicken.h $(CHICKEN_CONFIG_H)
+endif
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(PCRE_INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) 
$(C_COMPILER_SHARED_OPTIONS) \
          $(C_COMPILER_BUILD_UNSAFE_RUNTIME_OPTIONS) $(C_COMPILER_PCRE_OPTIONS) 
$< $(C_COMPILER_OUTPUT)
@@ -310,7 +318,11 @@
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) \
          $(C_COMPILER_BUILD_RUNTIME_OPTIONS) $< $(C_COMPILER_OUTPUT)
+ifeq ($(USE_HOST_PCRE),)
 regex-static$(O): regex.c chicken.h $(CHICKEN_CONFIG_H) $(PCRE_DIR)/pcre.h
+else
+regex-static$(O): regex.c chicken.h $(CHICKEN_CONFIG_H)
+endif
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(PCRE_INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) \
          $(C_COMPILER_BUILD_RUNTIME_OPTIONS) $(C_COMPILER_PCRE_OPTIONS) $< 
$(C_COMPILER_OUTPUT)
@@ -395,7 +407,11 @@
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) \
          $(C_COMPILER_BUILD_UNSAFE_RUNTIME_OPTIONS) $< $(C_COMPILER_OUTPUT)
+ifeq ($(USE_HOST_PCRE),)
 uregex-static$(O): uregex.c chicken.h $(CHICKEN_CONFIG_H) $(PCRE_DIR)/pcre.h
+else
+uregex-static$(O): uregex.c chicken.h $(CHICKEN_CONFIG_H)
+endif
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(C_COMPILER_PTABLES_OPTIONS) 
$(INCLUDES) \
          $(C_COMPILER_COMPILE_OPTION) $(C_COMPILER_OPTIMIZATION_OPTIONS) 
$(PCRE_INCLUDES) \
          $(C_COMPILER_BUILD_UNSAFE_RUNTIME_OPTIONS) $(C_COMPILER_PCRE_OPTIONS) 
$< $(C_COMPILER_OUTPUT)
@@ -489,6 +505,7 @@
 
 # pcre objects
 
+ifeq ($(USE_HOST_PCRE),)
 $(PCRE_DIR)/pcre_compile$(O): $(PCRE_DIR)/pcre_compile.c 
$(PCRE_DIR)/pcre_internal.h $(PCRE_DIR)/config.h $(CHICKEN_CONFIG_H) 
$(PCRE_DIR)/pcre.h $(PCRE_DIR)/ucp.h
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(PCRE_INCLUDES) 
$(C_COMPILER_COMPILE_OPTION) \
          $(C_COMPILER_OPTIMIZATION_OPTIONS) $(C_COMPILER_SHARED_OPTIONS) $< 
$(C_COMPILER_OUTPUT) \
@@ -652,6 +669,7 @@
        $(C_COMPILER) $(C_COMPILER_OPTIONS) $(PCRE_INCLUDES) 
$(C_COMPILER_COMPILE_OPTION) \
          $(C_COMPILER_OPTIMIZATION_OPTIONS) $(C_COMPILER_SHARED_OPTIONS) $< 
$(C_COMPILER_OUTPUT) \
          $(C_COMPILER_PCRE_OPTIONS)
+endif
 
 # assembler objects
 


-- 
CE3OH...