[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FIXED [PATCH] Report more information for unresolved identifiers in
From: |
megane |
Subject: |
Re: FIXED [PATCH] Report more information for unresolved identifiers in modules |
Date: |
Thu, 22 Apr 2021 13:31:18 +0300 |
User-agent: |
mu4e 1.0; emacs 28.0.50 |
Evan Hanson <evhan@foldling.org> writes:
> Cool, here is a signed off copy. But, I made some small changes, so if you
> or another hacker could have a look just to make sure you're OK with
> it?
Looks good, pushed!
>
> I fixed two places where the `resolve-variable` procedure didn't have the new
> `outer-ln` argument passed through,
Yikes, good catch! (Maybe there was a warning, but I didn't look for one.)
> But, I also capitalised the output messages to match the style in
> scrutinizer.scm and it now looks like the below when suggesting things, these
> are stylistic changes so I didn't want to push them directly, someone else can
> have a look and do that:
Yes, that's better for me. Thanks.