[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FIXED [PATCH] Report more information for unresolved identifiers in
From: |
Evan Hanson |
Subject: |
Re: FIXED [PATCH] Report more information for unresolved identifiers in modules |
Date: |
Mon, 19 Apr 2021 15:56:16 +1200 |
Cool, here is a signed off copy. But, I made some small changes, so if you
or another hacker could have a look just to make sure you're OK with it?
I fixed two places where the `resolve-variable` procedure didn't have the new
`outer-ln` argument passed through, and one typo in a string (changed "in2" to
"in"). These are pretty small tweaks, and necessary.
But, I also capitalised the output messages to match the style in
scrutinizer.scm and it now looks like the below when suggesting things, these
are stylistic changes so I didn't want to push them directly, someone else can
have a look and do that:
Error: Module `mod' has unresolved identifiers
In file `test.scm':
Unknown identifier `bar'
In procedure `foo' on line 10
Suggestion: try importing module `lexgen'
Unknown identifier `last'
On line 12
On line 17
Suggestion: try importing module `srfi-1'
Unknown identifier `baz'
On line 13
On line 16
Unknown identifier `string-index'
In procedure `foo' on line 14
In procedure `quux' on line 20
Suggestion: try importing one of these modules:
srfi-130
srfi-152
utf8-srfi-13
srfi-13
Cheers,
Evan
0001-Report-more-information-for-unresolved-identifiers-i.patch
Description: Text document