Re: [PATCH] Fix r7rs egg dependency list

[Mario Domenech Goulart]

On Mon, 12 Apr 2021 10:47:27 +0200 Peter Bex <peter@more-magic.net> wrote:

> The fix for #1185 (topological-sort) seems to have caused quite a
> regression on Salmonella.  See [1]; there are 22 eggs broken.  Most
> of those seem to have a dependency on r7rs, which is broken.
>
> It looks like the fix for topological-sort simply exposed bugs in
> existing eggs because components were missing dependency specifications
> on other components.  In the "bitstring" case that's pretty clear;
> there's simply a missing dependency of "bitstring" on "bitstring-lowlevel".
> This used to work because components would be built in the same order
> they were specified (if nothing else caused a rearrangement).
>
> If we look at the r7rs egg, it fails to build the "r7rs" module because
> it doesn't know about the (scheme base) module.  This is because it
> hasn't been built yet.  The attached patch seems to fix the situation by
> declaring a dependency of r7rs on the various modules under the
> "scheme" namespace.  I don't know if this is 100% correct (there
> may be other modules depending on other modules), so please review
> carefully.
>
> I think fixing this egg will probably restore most of the breakage.
>
> [1] 
> https://salmonella-linux-x86-64.call-cc.org/master/gcc/linux/x86-64/2021/04/12/yesterday-diff/

Thanks, Peter.  I've pushed your patch and released r7rs 1.0.4.

All the best.
Mario
-- 
http://parenteses.org/mario