Re: [Bug-XBoard] [bug #34980] Promotion in play at ICS fails with localized Xboard

[h.g. muller]

At 21:49 3-12-2011 +0000, Byrial Jensen wrote:
> Anyway I looked at the function PromotionCallback() in xboard.c and found this
> code:
>
> if (strcmp(name, _("Knight")) == 0) {
>         promoChar = 'n';
>     } else if (strcmp(name, _("Promote")) == 0) {
>         promoChar = '+';
>     } else if (strcmp(name, _("Defer")) == 0) {
>         promoChar = '=';
>     } else {
>         promoChar = ToLower(name[0]);
>     }

Indeed. And it is not just sent to the ICS, but would be used by XBoard 
internally
in any mode, most likely meaning the move would be refused, or give you a 
wrong piece.

This is one of the reasons I want to get rid of the promotion popup. 
(Remember there
are 22 different piece types for each color, and most of them are known 
under several
different names and ID letters depending on the variant they appear in.)

If it is up to me, the promotion popup can be considered deprecated, or 
even completely
removed from XBoard, so that the only choice left is between 'Almost always 
Queen'
and 'Always Queen'...