Re: [PATCH 1/3] libnetfs: new user callback: netfs_get_filemap()

[Samuel Thibault]

Joan Lledó, le dim. 19 déc. 2021 12:26:45 +0100, a ecrit:
> From: Joan Lledó <jlledom@member.fsf.org>
> 
> Provide the user with a new callback so they can implement file
> mapping over file system nodes.
> 
> * libnetfs/netfs.h: Add prototype for netfs_get_filemap

This only provides the declaration.

As I said, see how it's done in libnetfs/set-get-trans.c, there is the
definition in the .c file, and the declaration in netfs.h (which does
not need the weak attribute, only the definition needs it).

> ---
>  libnetfs/netfs.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/libnetfs/netfs.h b/libnetfs/netfs.h
> index 38182ab7..96d1eea8 100644
> --- a/libnetfs/netfs.h
> +++ b/libnetfs/netfs.h
> @@ -303,6 +303,12 @@ error_t netfs_get_dirents (struct iouser *cred, struct 
> node *dir,
>                          mach_msg_type_number_t *datacnt,
>                          vm_size_t bufsize, int *amt);
>  
> +/* The user may define this function. Return a memory object proxy port (send
> +   right) for the file contents of NP. PROT is the maximum allowable
> +   access. On errors, return MACH_PORT_NULL and set errno.  */
> +mach_port_t __attribute__ ((weak))
> +netfs_get_filemap (struct node *np, vm_prot_t prot);
> +
>  /* The user may define this function.  For a full description,
>     see hurd/hurd_types.h.  The default response indicates a network
>     store.  If the supplied buffers are not large enough, they should
> -- 
> 2.31.1