Re: [PATCH] Fix /proc/?/exe values for bootstrap processes

[Samuel Thibault]

Damien Zammit, le sam. 10 juil. 2021 20:30:07 +1000, a ecrit:
> @@ -1492,13 +1492,31 @@ S_startup_essential_task (mach_port_t server,
>            proc_mark_important (execproc);
>            proc_set_exe (execproc, "/hurd/exec");
>          }
> +      else if (!strcmp (name, "pci-arbiter"))
> +        {
> +          mach_port_t pciproc;
> +          proc_child (procserver, task);
> +          proc_task2proc (procserver, task, &pciproc);
> +          proc_mark_important (pciproc);
> +          proc_set_exe (pciproc, name);
> +        }
> +      else if (!strcmp (name, "rumpdisk"))
> +        {
> +          mach_port_t rumpdiskproc;
> +          proc_child (procserver, task);
> +          proc_task2proc (procserver, task, &rumpdiskproc);
> +          proc_mark_important (rumpdiskproc);
> +          proc_set_exe (rumpdiskproc, name);
> +        }

I'd say rather just factorize both into just one eventual "else" after
special-casing all the well-known processes?

> +      else if (!strcmp (name, "ext2fs"))
> +        fsinit = 1;
>        else if (!strcmp (name, "proc"))
>       procinit = 1;

Samuel