Re: [PATCH v2] startup: Mark essential tasks as our children

[Samuel Thibault]

Damien Zammit, le dim. 06 juin 2021 11:49:02 +1000, a ecrit:
> @@ -863,12 +867,12 @@ launch_core_servers (void)
>    assert_perror_backtrace (err);
>    proc_set_exe (procserver, "/hurd/startup");
>  
> -  /* Declare that the filesystem and auth are our children. */
> -  err = proc_child (procserver, fstask);
> -  assert_perror_backtrace (err);
> -  err = proc_child (procserver, authtask);
> +  /* XXX this seems required? */
> +  err = record_essential_task ("fs", fstask);

That record_essential_task call is normally already done in
S_startup_essential_task.

BTW at some point I rather suggested to let record_essential_task as it
is (it keeps a list of those), and in launch_core_servers just go
through the list to do the proc_child call. That would move less things
and bring less risks of moving stuff that shouldn't.

Samuel