bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH tarfs 3/6] Implement basic read-only mmap support


From: Samuel Thibault
Subject: Re: [RFC PATCH tarfs 3/6] Implement basic read-only mmap support
Date: Sat, 1 May 2021 18:30:05 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Sergey Bugaev, le sam. 01 mai 2021 19:27:45 +0300, a ecrit:
> On Sat, May 1, 2021 at 6:23 PM Samuel Thibault <samuel.thibault@gnu.org> 
> wrote:
> > This is missing the copyright head:ng.
> 
> Ah yes, sorry. Should I just put myself there, or "Hurd developers",
> or "Free Software Foundation, Inc."?..

Since this is not part of the main hurd repo there is no copyright
assignment requirement, so you can put your name. You can also assign
copyright and then put the FSF name.

> > > +      err = create_pager (node, &obj);
> >
> > Is the pager getting cleaned at some point?
> 
> The idea was that NODE_INFO(node)->pager does *not* itself keep a hard
> reference on the pager (create_pager () calls ports_port_deref (pager)
> after pager_get_port ()), so once all the pager clients are gone, the
> memory object would get garbage-collected, which would call
> pager_clear_user_data (), which sets NODE_INFO(node)->pager = NULL.

Does that also destroy the pager?

> But I was unable to test this in practice: Mach doesn't seem to want
> to do memory_object_terminate () even after the clients are gone.
> Perhaps it wants to keep the page cached while it has enough free
> memory.

It does.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]