bug#65924: git searches coreutils and util-linux commands in PATH

[Maxim Cournoyer]

Hi,

Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi Maxim,
>
> On Wed, 13 Sep 2023 at 14:00, Maxim Cournoyer <maxim.cournoyer@gmail.com> 
> wrote:
>
>> The 'git' command should be wrapped to include these in its PATH.
>
> $ guix size git-minimal
> [...]
> total: 147.8 MiB
>
> $ guix size git-minimal util-linux coreutils
> [...]
> total: 195.4 MiB
>
>
> It increases the size by 33% which is not nothing. :-)
>
> Is it only the subcommand git-submodule which is broken?  Probably not.
>
> $ find $(guix build git-minimal --no-grafts) -type f -exec grep -H 
> git-sh-setup {} \; | cut -f1 -d':' | xargs -I {} basename {}
> grep: 
> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/bin/scalar: 
> binary file matches
> grep: /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/bin/git: 
> binary file matches
> grep: 
> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/git-core/scalar:
>  binary file matches
> grep: 
> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/git-core/git:
>  binary file matches
> git-submodule
> git-filter-branch
> git-merge-resolve
> git-mergetool
> git-merge-octopus
> git-merge-one-file
> git-web--browse
> git-web--browse
> git-quiltimport
>
> The question could be: is worth to add 33% for these commands?

I'm not sure where uname is needed; we'd have to check.  util-linux is
where most of the weigh increase is at.  'git submodule' is part of
git-minimal; it should work without external tools, ideally.

References are also found in bin/git in your search, which suggests
perhaps the size of git-minimal is a "lie" (the core package is not
fully functional).

-- 
Thanks,
Maxim