[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65575: [PATCH v3 4/4] gnu: emacs: Reload subdirs.el files in 'guix-e
From: |
Liliana Marie Prikler |
Subject: |
bug#65575: [PATCH v3 4/4] gnu: emacs: Reload subdirs.el files in 'guix-emacs-autoload-packages'. |
Date: |
Sat, 02 Sep 2023 06:49:27 +0200 |
User-agent: |
Evolution 3.46.4 |
Am Freitag, dem 01.09.2023 um 00:53 -0400 schrieb Maxim Cournoyer:
> This fixes a regression introduced with 79cfe30f3 ("build-system:
> emacs: Use subdirectories again.") which caused the
> 'guix-emacs-autoload-packages' to no longer be able to autoload all
> packages.
>
> * gnu/packages/aux-files/emacs/guix-emacs.el
> (guix-emacs-autoload-packages): Reload subdirs.el files unless NO-
> RELOAD is provided. Update doc.
> * doc/guix.texi (Application Setup): Document that
> 'guix-emacs-autoload-packages' can be invoked interactively to auto-
> reload newly installed Emacs packages.
> * gnu/packages/emacs.scm (emacs) [arguments] <phases>: Call
> guix-emacs-autoload-packages with an argument in the site-start.el
> file.
>
> ---
>
> Changes in v3:
> - Invert argument logic of guix-emacs-autoload-packages
> - Drop the guix-emacs-autoload-packages-called state variable
> - Adjust site-start.el file in Emacs package
>
> Changes in v2:
> - Safely load subdirs.el files
> - Add 'reload' prefix argument as override for guix-emacs-autoload-
> packages
>
> doc/guix.texi | 11 +++++++----
> gnu/packages/aux-files/emacs/guix-emacs.el | 15 ++++++++++++---
> gnu/packages/emacs.scm | 2 +-
> 3 files changed, 20 insertions(+), 8 deletions(-)
Thanks, LGTM. I've tested this by dropping almost all parts of load-
path and calling (guix-emacs-autoload-packages), it appears to do
what's promised. Queued locally for emacs-next and followed up with a
patch that fixes the compilation warnings coming from the docstrings.
Cheers