[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54097: bug#63001: bug#63631: [PATCH] import: go: Handle subpackage v
From: |
Simon Tournier |
Subject: |
bug#54097: bug#63001: bug#63631: [PATCH] import: go: Handle subpackage versioning correctly. |
Date: |
Wed, 16 Aug 2023 17:59:53 +0200 |
Hi Timo,
On Sat, 17 Jun 2023 at 17:12, "Timo Wilken" <guix@twilken.net> wrote:
>> What would you suggest? Simon?
>
> Here's a brief comparison between Simon's patches and mine -- Simon's seem to
> contain fixes for a couple more things than mine currently does:
>
> 1. Simon sorts available versions in an error message; this can presumably be
> merged independently since it doesn't conflict with other patches.
>
> 2. Simon always prepends a "SUBDIR/" prefix to the tag if found, whereas I try
> to find the plain "vX" tag first, then fall back to "SUBDIR/vX". Judging by
> https://go.dev/ref/mod#vcs-version, Simon's approach seems more correct.
> I'll change my implementation to match and try it out.
>
> 3. For detecting the `module-path-subdirectory' in Simon's patches: that's the
> same approach I used initially, but I found I have to try `(substring
> module-path (string-length import-prefix))' first (to handle e.g.
> cloud.google.com/go/*). This is one of the things I haven't submitted
> yet...
Sorry if I have missed some patches or overlooked something. Do you
plan to send another patch series handling all?
Cheers,
simon
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#54097: bug#63001: bug#63631: [PATCH] import: go: Handle subpackage versioning correctly.,
Simon Tournier <=