[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64365: [Shepherd] Export deregister-service.
From: |
Bruno Victal |
Subject: |
bug#64365: [Shepherd] Export deregister-service. |
Date: |
Thu, 13 Jul 2023 04:10:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 |
Hi Ludo’,
On 2023-07-12 21:52, Ludovic Courtès wrote:
> Hi,
>
> Bruno Victal <mirai@makinata.eu> skribis:
>
>> Although 'register-services' is exported its counterpart
>> 'deregister-service' is not.
>>
>> Some notes:
>> * 'register-services' is in its plural form while its counterpart
>> is not, maybe one of them should be renamed for consistency sake?
>>
>> * From the docstring and code the interface of 'deregister-service'
>> seems to differ from 'register-services' though I haven't
>> confirmed it. Perhaps add some documented examples for reference?
>
> All good points. Since ‘deregister-service’ is an internal helper with
> a clunky interface (it takes a string, special-cases "all", prints
> messages), I propose exposing ‘unregister-services’ as defined below.
>
> WDYT?
Neat, LGTM.
--
Furthermore, I consider that nonfree software must be eradicated.
Cheers,
Bruno.