[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63082: [PATCH v3 02/16] services: mpd: Add an 'update' action to tri
From: |
Bruno Victal |
Subject: |
bug#63082: [PATCH v3 02/16] services: mpd: Add an 'update' action to trigger a database update. |
Date: |
Wed, 24 May 2023 17:00:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 |
Hi Maxim,
On 2023-05-05 19:28, Maxim Cournoyer wrote:
> * gnu/services/audio.scm (mpd-shepherd-service): Register a new update action.
> * doc/guix.texi (Audio Services): Document it.
> ---
> doc/guix.texi | 10 ++++++++++
> gnu/services/audio.scm | 11 +++++++++++
> 2 files changed, 21 insertions(+)
>
I've been looking at this part for the past few weeks in attempt to
make it more robust and after countless hours, I'd advise against this
(in its current form), reason being that this only works if your
configuration happens to match the default values used by mpc.
My attempts at getting the values from the configuration into
something that mpc understands have been unsuccessful. Not only the
decision “logic” of what values to pass is non-trivial, parsing the
endpoints field has been so far a complete nightmare. (with interesting
gems like IPv6 address formats that the daemon is happy to use yet
mpc will reject)
Having the proper hostname (and port) intelligently deduced from
the endpoints field is a big minefield that is likely to end in
unmaintainable spaghetti.
Short of introducing additional fields like “internal-mpc-host” and
“internal-mpc-port”, you could modify this to relay the
'environment-variables' field for mpc as well. (since it can make use
of the MPD_HOST and MPD_PORT varibles if present)
--
Furthermore, I consider that nonfree software must be eradicated.
Cheers,
Bruno.
- bug#63082: [PATCH v3 00/16] Improve out-of-the-box experience with mpd-service-type, Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 01/16] services: mpd: Add auto-update? field to mpd-configuration., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 02/16] services: mpd: Add an 'update' action to trigger a database update., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 02/16] services: mpd: Add an 'update' action to trigger a database update.,
Bruno Victal <=
- bug#63082: [PATCH v3 11/16] system: accounts: Export <user-account>., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 13/16] services: mpd: Auto-detect mpd-output mixer type by default., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 04/16] services: mpd: Rename %set-user-group to set-user-group., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 03/16] services: mpd: Streamline mpd-user-sanitizer and mympd-user-sanitizer., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 07/16] services: mpd; Refactor start slot directory initialization., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 10/16] services: mpd: Let Shepherd effect the user/group change., Maxim Cournoyer, 2023/05/05