[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc he
From: |
Maxim Cournoyer |
Subject: |
bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header. |
Date: |
Thu, 11 May 2023 09:18:46 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Arun,
Arun Isaac <arunisaac@systemreboot.net> writes:
> Hi Maxim,
>
> Thank you for the updated patch! :-) It LGTM. Please push.
>
>> OK! I opted for simplicity and double-quoted all the names.
>
> Fair enough. Though a check is only one condition away! ;-)
>
> (if (string-contains? (person-name member) ",")
> (string-append "\"" (person-name member) "\"")
> (person-name member))
It's string-contains without ?, apparently. Let's try this (and save a
few bytes per submission :-)):
--8<---------------cut here---------------start------------->8---
modified etc/teams.scm.in
@@ -618,7 +618,11 @@ (define (sort-members members)
(define (member->string member)
"Return the 'email <name>' string representation of MEMBER."
- (format #false "\"~a\" <~a>" (person-name member) (person-email member)))
+ (let* ((name (person-name member))
+ (quoted-name/maybe (if (string-contains name ",")
+ (string-append "\"" name "\"")
+ name)))
+ (format #false "~a <~a>" quoted-name/maybe (person-email member))))
(define* (list-members team #:optional port (prefix ""))
"Print the members of the given TEAM."
--8<---------------cut here---------------end--------------->8---
The change is now installed; thanks for the review!
--
Thanks,
Maxim
bug#63378: [PATCH v2] teams: Fix script to produce a single X-Debbugs-Cc header., Maxim Cournoyer, 2023/05/09