[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field.
From: |
Maxim Cournoyer |
Subject: |
bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field. |
Date: |
Sat, 06 May 2023 22:55:07 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi!
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Freitag, dem 05.05.2023 um 14:29 -0400 schrieb Maxim Cournoyer:
>> Prior to this change, there was a discrepancy where a user could have
>> disagreeing groups between the group and user fields (the user field
>> being a <user-account> record, which includes its primary group as a
>> string). This could have caused problems because the USER's group
>> was being used to set the file permissions, while the GROUP name was
>> serialized to MPD's configuration, and MPD would use it to set the
>> group of its running process.
> Didn't we agree in v2 that we want to address this on the account-
> service level? Unless the rest of this series somehow depends on this
> patch, I'd rather delay it until we have a proper solution.
I think we agreed the idea to have <user-account> support <user-group>
objects for its group field was a good idea that should be implemented,
but I declined doing this new work as part of this series :-).
>> Synchronizing both is not practical, as it can easily lead to
>> slightly different <user-account> objects conflicting, again causing
>> problems.
> It might not be practical to do so inside the service, but note how
> this has already become an effort in defensive programming. There are
> easier ways to not make this a problem on the configuration level,
> namely by specifying the same group for both user and group fields. As
> far as I see this is even the default state of being if the user is
> supplied as a string.
I really don't like the group information being duplicated in both the
user and a distinct field; it's an awkward API that raises more
questions than it provides answers, in my opinion (non-intuitive). One
of the reasons I came think this way is because a <user-group> can
differ by being a system group or not, which would make it easy to
introduce unexpected, subtle variants.
--
Thanks,
Maxim
- bug#63082: [PATCH v3 07/16] services: mpd; Refactor start slot directory initialization., (continued)
- bug#63082: [PATCH v3 10/16] services: mpd: Let Shepherd effect the user/group change., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 09/16] services: mpd: Do not rotate logs when using syslog., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 14/16] services: mpd: Provision a default cache directory and set HOME., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 16/16] services: Avoid 'delete' overrides warning in audio module., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 15/16] services: mpd: Update basic example., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 06/16] services: mpd: List log-level in decreasing verbosity order in doc., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/05/05
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field.,
Maxim Cournoyer <=
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/05/08
bug#63082: [PATCH v3 08/16] services: mpd: Log to syslog by default., Maxim Cournoyer, 2023/05/05
bug#63082: [PATCH v3 12/16] services: mpd: Warn when the MPD user is not in the "audio" group., Maxim Cournoyer, 2023/05/05