[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field.
From: |
Liliana Marie Prikler |
Subject: |
bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field. |
Date: |
Fri, 05 May 2023 21:51:59 +0200 |
User-agent: |
Evolution 3.46.4 |
Am Freitag, dem 05.05.2023 um 14:29 -0400 schrieb Maxim Cournoyer:
> Prior to this change, there was a discrepancy where a user could have
> disagreeing groups between the group and user fields (the user field
> being a <user-account> record, which includes its primary group as a
> string). This could have caused problems because the USER's group
> was being used to set the file permissions, while the GROUP name was
> serialized to MPD's configuration, and MPD would use it to set the
> group of its running process.
Didn't we agree in v2 that we want to address this on the account-
service level? Unless the rest of this series somehow depends on this
patch, I'd rather delay it until we have a proper solution.
> Synchronizing both is not practical, as it can easily lead to
> slightly different <user-account> objects conflicting, again causing
> problems.
It might not be practical to do so inside the service, but note how
this has already become an effort in defensive programming. There are
easier ways to not make this a problem on the configuration level,
namely by specifying the same group for both user and group fields. As
far as I see this is even the default state of being if the user is
supplied as a string.
Cheers
- bug#63082: [PATCH v3 07/16] services: mpd; Refactor start slot directory initialization., (continued)
- bug#63082: [PATCH v3 07/16] services: mpd; Refactor start slot directory initialization., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 10/16] services: mpd: Let Shepherd effect the user/group change., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 09/16] services: mpd: Do not rotate logs when using syslog., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 14/16] services: mpd: Provision a default cache directory and set HOME., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 16/16] services: Avoid 'delete' overrides warning in audio module., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 15/16] services: mpd: Update basic example., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 06/16] services: mpd: List log-level in decreasing verbosity order in doc., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/05/05
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field.,
Liliana Marie Prikler <=
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/05/06
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/05/07
- bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/05/08
bug#63082: [PATCH v3 08/16] services: mpd: Log to syslog by default., Maxim Cournoyer, 2023/05/05
bug#63082: [PATCH v3 12/16] services: mpd: Warn when the MPD user is not in the "audio" group., Maxim Cournoyer, 2023/05/05