[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63082: [PATCH 06/17] services: mympd: Fix log file name.
From: |
Bruno Victal |
Subject: |
bug#63082: [PATCH 06/17] services: mympd: Fix log file name. |
Date: |
Sat, 29 Apr 2023 02:56:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 |
On 2023-04-29 02:49, Maxim Cournoyer wrote:
>> No, this is correct although perhaps /var/log/mympd/mympd.log would have
>> been less error prone?
>> IIRC mympd is supposed to write to a subdirectory within /var/log and
>> this change would break the service.
>
> The only consumer of a 'log-to' is Shepherd, as far as I can see; so
> mympd doesn't get to know where the log is going (its output goes to
> stdout/stderr, captured by Shepherd), so shouldn't be writing anything
> under /var/log/mympd. Looking at upstream, they ship a fancy systemd
> service which wouldn't log to text files but to the journal, closer in
> spirit to syslog.
Oh you're right, I must have been misremembering this.
> For symmetry with mpd, I've now adjusted logging of mympd to default to
> syslog (and found it had an erroneous requirement on 'syslog rather than
> syslogd with the test :-)).
>
Nice!
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., (continued)
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/04/29
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/04/29
bug#63082: [PATCH 02/17] services: mpd: Streamline mpd-user-sanitizer and mympd-user-sanitizer., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 03/17] services: mpd: Rename %set-user-group to set-user-group., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 06/17] services: mympd: Fix log file name., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 13/17] services: mpd: Fix indentation., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 09/17] services: mpd: Let Shepherd effect the user/group change., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 14/17] services: mpd: Obsolete 'environment-variables' field., Maxim Cournoyer, 2023/04/28
bug#63082: [PATCH 07/17] services: mpd: Log to syslog by default., Maxim Cournoyer, 2023/04/28