[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63082: [PATCH 12/17] services: mpd: Auto-detect mpd-output mixer typ
From: |
Maxim Cournoyer |
Subject: |
bug#63082: [PATCH 12/17] services: mpd: Auto-detect mpd-output mixer type by default. |
Date: |
Fri, 28 Apr 2023 10:27:05 -0400 |
Relates to <https://issues.guix.gnu.org/63082>.
* gnu/services/audio.scm (mpd-output) [mixer-type]: Change default value from
"none" to unspecified.
* doc/guix.texi (Audio Services): Regenerate doc.
---
doc/guix.texi | 11 +++++++----
gnu/services/audio.scm | 15 +++++++++------
2 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 19320c2185..550e6606e5 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -33709,8 +33709,9 @@ Audio Services
@end table
@end deftp
+@c %start of fragment
@deftp {Data Type} mpd-output
-Data type representing a @command{mpd} audio output.
+Available @code{mpd-output} fields are:
@table @asis
@item @code{name} (default: @code{"MPD"}) (type: string)
@@ -33737,15 +33738,16 @@ Audio Services
@item @code{always-on?} (default: @code{#f}) (type: boolean)
If set to @code{#t}, then MPD attempts to keep this audio output always
-open. This may be useful for streaming servers, when you don?t want to
+open. This may be useful for streaming servers, when you don’t want to
disconnect all listeners even when playback is accidentally stopped.
-@item @code{mixer-type} (default: @code{"none"}) (type: string)
+@item @code{mixer-type} (type: maybe-string)
This field accepts a string that specifies which mixer should be used
for this audio output: the @code{hardware} mixer, the @code{software}
mixer, the @code{null} mixer (allows setting the volume, but with no
effect; this can be used as a trick to implement an external mixer
-External Mixer) or no mixer (@code{none}).
+External Mixer) or no mixer (@code{none}). When left unspecified, a
+@code{hardware} mixer is used for devices that support it.
@item @code{replay-gain-handler} (type: maybe-string)
This field accepts a string that specifies how
@@ -33760,6 +33762,7 @@ Audio Services
@end table
@end deftp
+@c %end of fragment
The following example shows a configuration of @command{mpd} that
configures some of its plugins and provides a HTTP audio streaming output.
diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index 9579432ea3..071cebcef4 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -343,15 +343,18 @@ (define-configuration mpd-output
disconnect all listeners even when playback is accidentally stopped.")
(mixer-type
- (string "none")
- "This field accepts a string that specifies which mixer should be used
-for this audio output: the @code{hardware} mixer, the @code{software}
-mixer, the @code{null} mixer (allows setting the volume, but with no
-effect; this can be used as a trick to implement an external mixer
-External Mixer) or no mixer (@code{none})."
+ maybe-string
+ "This field accepts a string that specifies which mixer should be used for
+this audio output: the @code{hardware} mixer, the @code{software} mixer, the
+@code{null} mixer (allows setting the volume, but with no effect; this can be
+used as a trick to implement an external mixer External Mixer) or no
+mixer (@code{none}). When left unspecified, a @code{hardware} mixer is used
+for devices that support it."
(sanitizer
(lambda (x) ; TODO: deprecated, remove me later.
(cond
+ ((eq? %unset-value x)
+ x)
((symbol? x)
(warning (G_ "symbol value for 'mixer-type' is deprecated, \
use string instead~%"))
--
2.39.2
- bug#63082: mpd defaul configuration does not work ('No database' error), (continued)
- bug#63082: mpd defaul configuration does not work ('No database' error), Maxim Cournoyer, 2023/04/25
- bug#63082: [PATCH 00/17] Improve out-of-the-box experience with mpd-service-type, Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 01/17] services: mpd: Add an 'update' action to trigger a database update., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 05/17] services: mpd: List log-level in decreasing verbosity order in doc., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 10/17] system: accounts: Export <user-account>., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 16/17] services: mpd: Update basic example., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 11/17] services: mpd: Warn when the MPD user is not in the "audio" group., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 12/17] services: mpd: Auto-detect mpd-output mixer type by default.,
Maxim Cournoyer <=
- bug#63082: [PATCH 15/17] services: mpd: Provision a default cache directory and set HOME., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 08/17] services: mpd: Only rotate log when a log file is specified., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Maxim Cournoyer, 2023/04/28
- bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field., Liliana Marie Prikler, 2023/04/29