bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs

[Roman Scherer]

Hi Liliana and Maxime,

if the icons are really coming from [1], they seem to be licensed under
the Creative Commons Attribution 4.0 International Public License.

If it is okay to include them, I could work on a patch that only
installs the VS Code icons. I think we need to give credit and link to
the Creative Commons license. Is it enough to add it to the license
field and mention/link the VS Code icons in the description field?

Before doing that, I would wait until someone clarified that the icons
are really coming from [1] in the upstream issue.

In the meantime I think it's best to include my patch that removes all
icons from the source.

What do you think?

Roman

[1] https://github.com/microsoft/vscode-icons

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Hi Roman,
>
> Am Sonntag, dem 20.03.2022 um 12:21 +0100 schrieb Roman Scherer:
>>
>> Hi Liliana,
>>
>> thanks for adding the comment locally. I just checked the source of
>> LSP Treemacs and yes, they are all mentioned by name here:
>>
>> https://github.com/emacs-lsp/lsp-treemacs/blob/master/lsp-treemacs-themes.el#L38
>>
>> Is this a problem? Should the build script remove them?
>>
>> If that's the case, we could remove all those "icon themes" and just
>> leave this "Iconless" theme in the file:
>>
>> https://github.com/emacs-lsp/lsp-treemacs/blob/master/lsp-treemacs-themes.el#L209
>>
>> Roman
> Sadly, replacing these in a snippet won't be that easy, given we can't
> easily sneak emacs into it.  On the topic of icons to remove, vscode-
> icons might actually be okay and are also required by default.
>
> What should we do?

signature.asc
Description: PGP signature