[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs
From: |
Liliana Marie Prikler |
Subject: |
bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs |
Date: |
Sun, 20 Mar 2022 12:15:48 +0100 |
User-agent: |
Evolution 3.42.1 |
Hi Roman, hi Maxime,
Am Sonntag, dem 20.03.2022 um 11:35 +0100 schrieb Roman Scherer:
> Hi Maxime,
>
> ok, I see. Thanks for the explanation. I attached a patch that
> removes the icons from the source as per your suggestion.
>
> What do you think about this one?
>
> Thanks, Roman.
The logic behind your patch LGTM, but it lacks an explanatory comment.
Don't worry about resending the patch, though -- I already added the
comment locally and am currently looking to also apply this to emacs-
company-box. If either of you could check whether those icons are
referred to by name in emacs-lsp-treemacs while I'm working on company-
box, that'd be appreciated.
Cheers
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Roman Scherer, 2022/03/19
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Maxime Devos, 2022/03/19
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Roman Scherer, 2022/03/20
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Maxime Devos, 2022/03/20
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Roman Scherer, 2022/03/20
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs,
Liliana Marie Prikler <=
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Roman Scherer, 2022/03/20
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Liliana Marie Prikler, 2022/03/20
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Roman Scherer, 2022/03/20
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Liliana Marie Prikler, 2022/03/20
- bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs, Roman Scherer, 2022/03/20