[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41541: [PATCH 3/8] system: Add 'multiboot-modules' field to <boot-pa
From: |
Jan Nieuwenhuizen |
Subject: |
bug#41541: [PATCH 3/8] system: Add 'multiboot-modules' field to <boot-parameters>. |
Date: |
Sat, 06 Jun 2020 12:13:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Mathieu Othacehe writes:
Hello!
>> + (mach (if (%current-target-system)
>> + ;; A cross-built GNUmach does not work
>> + (with-parameters ((%current-system "i686-linux")
>> + (%current-target-system #f))
>> + mach)
>
> Maybe it would make more sense to check if we are on a Hurd system,
> rather than just checking for %current-target-system to be set, don't
> know.
Ah yes. When this IF runs we already checked that we are building a
hurd system; this adds two lines leading up to the above snippet
(if (operating-system-hurd os)
(let* ((mach (operating-system-kernel os))
(mach (if (%current-target-system)
...but that means that this last IF is maybe unnecessarily implicit and
only really makes sense by adding/remembering that context. Changed it
to
(mach (if (and=> (%current-target-system) hurd-triplet?)
I guess that's friendlier?
>> + (libc (if target
>> + (with-parameters ((%current-target-system #f))
>> + (cross-libc target))
>> + glibc))
>
> In the future, it would be nice to make this think transparent. Anyway,
> for now this is the best we can do I think.
Yes, I've added a comment
;; TODO: cross-libc has extra patches for the Hurd;
;; remove in next rebuild cycle
(cross-libc target))
I have now 8 squash! commits; I'll be resetting wip-hurd-vm just once
more before merging, after checking in with Ludovic and re-running some
tests.
Really looking forward to seeing a Guix Hurd VM hookup-up in bayfront
and really start building a Hurd system, mabye we'll see some more
people join in. I think that should be (almost?) possible after
merging, right?
Greetings, Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | AvatarĀ® http://AvatarAcademy.com
- bug#41541: [PATCH 0/9] Merge wip-hurd-vm "last review round", Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 1/8] system: Add 'hurd' field to <operating-system>., Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 3/8] system: Add 'multiboot-modules' field to <boot-parameters>., Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 5/8] system: Use 'hurd' package in label., Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 2/8] bootloader: Extend `<menu-entry>' for multiboot., Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 7/8] services: hurd: Add `hurd-etc-service'., Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 4/8] bootloader: grub: Add support for multiboot., Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 6/8] system: examples: Add bare-hurd.tmpl., Jan (janneke) Nieuwenhuizen, 2020/06/04
- bug#41541: [PATCH 8/8] system: Add `hurd-activation'., Jan (janneke) Nieuwenhuizen, 2020/06/04