[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36785: Impossible to pull on foreign distro
From: |
Ricardo Wurmus |
Subject: |
bug#36785: Impossible to pull on foreign distro |
Date: |
Wed, 18 Sep 2019 20:35:19 +0200 |
User-agent: |
mu4e 1.2.0; emacs 26.2 |
Ludovic Courtès <address@hidden> writes:
> Digging further, I fetched the source from
> <https://packages.ubuntu.com/bionic/sudo>, and boom! I found the
> culprit: it’s called ‘debian/patches/keep_home_by_default.patch’.
>
> --8<---------------cut here---------------start------------->8---
> Description: Set HOME in initial_keepenv_table
> Set HOME in initial_keepenv_table; without this, $HOME will never be
> preserved unless added to keep_env. There's appropriate logic to handle
> resetting the home for -H and -i options, so this is the only part that's
> missing.
> Author: Steve Langasek <address@hidden>
> --- a/plugins/sudoers/env.c
> +++ b/plugins/sudoers/env.c
> @@ -189,6 +189,7 @@
> "COLORS",
> "DISPLAY",
> "DPKG_COLORS",
> + "HOME",
> "HOSTNAME",
> "KRB5CCNAME",
> "LS_COLORS",
> --8<---------------cut here---------------end--------------->8---
>
> (This patch is playing with fire IMO. If you’re an Ubuntu user,
> consider reporting a bug!)
Wow. Changing fundamental behaviour like that is bad.
> We could apply the patch I posted earlier, which simply disables profile
> migration when SUDO_USER is set. That won’t address the fact that root
> writes to the user’s ~/.cache, but there’s not much we can do here.
This sounds fine to me.
--
Ricardo
- bug#36785: Impossible to pull on foreign distro, Ludovic Courtès, 2019/09/17
- bug#36785: Impossible to pull on foreign distro, Gábor Boskovits, 2019/09/17
- bug#36785: Impossible to pull on foreign distro, Ludovic Courtès, 2019/09/18
- bug#36785: Impossible to pull on foreign distro, Maxim Cournoyer, 2019/09/20
- bug#36785: Impossible to pull on foreign distro, Ludovic Courtès, 2019/09/20
- bug#36785: Impossible to pull on foreign distro, Maxim Cournoyer, 2019/09/21
- bug#36785: Impossible to pull on foreign distro, Ludovic Courtès, 2019/09/23
- bug#36785: Impossible to pull on foreign distro, Gábor Boskovits, 2019/09/23
- bug#36785: Impossible to pull on foreign distro, Ludovic Courtès, 2019/09/23
- bug#36785: Impossible to pull on foreign distro, Maxim Cournoyer, 2019/09/21
bug#36785: Impossible to pull on foreign distro,
Ricardo Wurmus <=