bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #63142] [troff] unsupport newlines as escape argument delimiters


From: G. Branden Robinson
Subject: [bug #63142] [troff] unsupport newlines as escape argument delimiters
Date: Mon, 19 Aug 2024 20:40:12 -0400 (EDT)

Update of bug #63142 (group groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #4:


commit 1e53037d5d3f934cf89081436f39f87ff2f2efad
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Aug 19 14:11:56 2024 -0500

    [troff]: Fix Savannah #63142 (newlines as delims).
    
    Withdraw support for newlines as escape sequence delimiters.  Only a few
    (6) supported this, and the rationale behind it is unknown.  DWB 3.3
    troff didn't behave this way in any case.
    
    * src/roff/troff/input.cpp (do_overstrike, do_bracket, do_name_test)
      (do_zero_width_output, do_width, do_device_control): Do it.  As a
      bonus, check starting delimters for these escape sequences
      (`\[obAZwX]`) for validity in general.
    
      (do_overstrike, do_bracket, do_zero_width_output): When returning
      early, delete the `new` node we just allocated to avoid leaking
      memory.
    
      (token:next): Be prepared for the `\b` and `\o` escape sequences
      to return a null pointer (if the sequence doesn't even validly
      get off the ground), as `\Z` and `\X` already do.
    
    * src/roff/groff/tests/some_escapes_accept_newline_delimiters.sh:
      Delete.
    * src/roff/groff/groff.am (groff_TESTS): Drop test.
    
    * doc/groff.texi.in (Delimiters):
    * man/groff.7.man (Delimiters):
    * NEWS: De-document support for newlines as delimiters.
    
    Fixes <https://savannah.gnu.org/bugs/?63142>.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63142>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]