[bug #46914] .ce sometimes ignores right margin

[Dave]

Follow-up Comment #8, bug #46914 (project groff):

[comment #7 comment #7:]
> This also makes sense as centering and filling are incompatible
> goals.

They aren't conceptually; this

$ printf '.ce 2\nHello,\nworld!\n' | nroff | cat -s
                             Hello,
                             world!

could have just as easily been designed to output

                         Hello, world!

but no roff ever written fills input lines while .ce is active, so the fact
that it _could_ have been done another way is a moot point.

> The variable "was_centered" is not used in the current subroutine
> "possible_break_line".

(For anyone else trying to find this function, its correct name is
possibly_break_line.)  possibly_break_line() does pass was_centered as the
third argument in its call to output_line(). I guess you mean was_centered
isn't used directly by possibly_break_line() itself?

> src/roff/troff/env.cpp: possibly_break_line: return at once, if lines
> are to be centered and fill mode is active

Is the purpose of this change to require the user to explicitly disable fill
mode before calling .ce?  I disagree with that change, but I might also be
misunderstanding you, because your later ce.roff calls .ce with fill mode
active.

> Lines to be centered should neither be filled nor broken.
> This shows a defect in the input file's layout.

I don't follow your meaning here.  Are you talking about a specific input
file, and if so, which one?  Or do you generally mean input files that call
.ce while filling is active?


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?46914>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/