[bug #62398] .../troff/input.cpp: argument "len" is zero in "new unsigned char[len]"

[G. Branden Robinson]

Update of bug #62398 (project groff):

                  Status:                    None => Ready for Merge        
             Assigned to:                    None => gbranden               

    _______________________________________________________

Follow-up Comment #10:


commit c09128d9ef8c8181e61614ae762308d2ac27b29f
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Apr 3 19:30:56 2023 -0500

    [troff]: Skip allocation of zero-length arrays.
    
    * src/roff/troff/input.cpp (temp_iterator::temp_iterator): Skip
      allocation of zero-length arrays.  Resolves "-Walloc-zero" warning
      from GCC.
    
    Fixes <https://savannah.gnu.org/bugs/?62398>.  Thanks to Bjarni Ingi
    Gislason for the report.
    
    It is not necessary to make conditional the subsequent `delete[]` of a
    null pointer.  "If the _delete-expression_ calls the implementation
    deallocation function (3.7.3.2), and if the operand of the delete
    expression is not null pointer constant, the deallocation function will
    deallocate the storage referenced by the pointer thus rendering the
    pointer invalid" (ISO/IEC 14882-1998, §5.3.5, paragraph 4).  Or as
    Stroustrup puts it, "Applying _delete_ to zero has no effect." (_The C++
    Programming Language, Special Edition_, p. 128).




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62398>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/