[bug #63824] revert recent change to skip tests at configuration time

[G. Branden Robinson]

Follow-up Comment #3, bug #63824 (project groff):

[comment #2 comment #2:]
> Have you looked at the --check flag of BuildFoundries?

Somewhat.

> It is intended to report whether BuildFoundries will succeed in populating
the download file in devpdf. However, there is a chicken/egg problem, in order
to be called from configure it needs to be "made" i.e. populate @PERL@,
@GROFF_GHOSTSCRIPT_INTERPRETERS@ and @PATH_SEPARATOR@ with sed or whatever
does it and made executable. I don't know if it is possible.

It should be possible, I think: Autoconf tests construct C source files based
on Autoconf-determined parameters and compile them to determine the values of
other Autoconf parameters all the time.

An Autoconf check that AC_REQUIREs GROFF_AWK_PATH can be sure that $AWK is
populated (if missing, it won't run at all).  Similarly, one that AC_REQUIREs
GROFF_GHOSTSCRIPT_PATH can be sure that $GHOSTSCRIPT is populated (or the
check won't be run).

(I am not sure it is necessary to mess with
@GROFF_GHOSTSCRIPT_INTERPRETERS@...we should already know what name is being
used for Ghostscript by that time, and not have to search.)

So I think such a check we write can be fully and correctly parameterized at
./configure-time.

However I think I want to leave that adventure for groff 1.23++.  Too many
times when I think something will be straightforward, I end up with canid
tooth marks in my gluteus maxima.

Here is a diff of my changes in preparation to proceed as discussed in comment
#0 for gropdf.  I revised the texts of the notice as discussed and to
otherwise bring them up to date with facts.


diff --git a/font/devpdf/devpdf.am b/font/devpdf/devpdf.am
index ddf34e625..4b872182d 100644
--- a/font/devpdf/devpdf.am
+++ b/font/devpdf/devpdf.am
@@ -178,12 +178,9 @@ uninstall_devpdf:
          rmdir $(DESTDIR)$(devpdffontdir); \
        fi
 
-if USE_GROPDF
-font_devpdf_TESTS = font/devpdf/tests/check-default-foundry.sh
-if HAVE_URW_FONTS
-font_devpdf_TESTS += font/devpdf/tests/check-urw-foundry.sh
-endif
-endif
+font_devpdf_TESTS = \
+  font/devpdf/tests/check-default-foundry.sh \
+  font/devpdf/tests/check-urw-foundry.sh
 
 TESTS += $(font_devpdf_TESTS)
 EXTRA_DIST += $(font_devpdf_TESTS)
diff --git a/m4/groff.m4 b/m4/groff.m4
index af2ddfdcd..b6c5535be 100644
--- a/m4/groff.m4
+++ b/m4/groff.m4
@@ -325,13 +325,15 @@ AC_DEFUN([GROFF_GROPDF_PROGRAM_NOTICE], [
   then
     AC_MSG_NOTICE(['gropdf' will have reduced function.
 
-  Because neither Ghostscript nor URW fonts are available, groff
-  documentation will not be available in PDF.
+  Neither Ghostscript nor URW fonts are available; groff documentation
+  thus will not be available in PDF.
 
   'gropdf' will be able to handle only documents using the standard PDF
   base 14 fonts, plus the 'EURO' font groff supplies, and font embedding
   with its '-e' option (accessed via the 'groff' command with the option
   '-P -e') will not be possible.
+
+  If you run "make check", an automated test for 'gropdf' will fail.
 ])
   fi
 ])
@@ -363,6 +365,7 @@ AC_DEFUN([GROFF_URW_FONTS_CHECK], [
     _list_paths=`$GHOSTSCRIPT -h | $AWK 'BEGIN { found = 0 } /Search path:/ {
found = 1 } /^[ ]*\// { print $'0' }'| tr : ' '`
   fi
 
+dnl Keep this list in sync with font/devpdf/Foundry.in.
   _list_paths="$_list_paths \
     /usr/share/fonts/type1/gsfonts/ \
     /usr/share/fonts/default/Type1/ \
@@ -409,12 +412,16 @@ AC_DEFUN([GROFF_URW_FONTS_NOTICE], [
   then
     AC_MSG_NOTICE([URW fonts in Type 1/PFB format were not found.
 
-  URW font generation for groff's 'gropdf' output driver will not work
-  properly.  You can obtain the URW base 35 fonts from their GitHub
-  project.
+  groff font description files for the URW fonts, used by the 'gropdf'
+  output driver, will not be available.  Use and embedding of fonts from
+  the 'U' foundry in PDF documents generated by groff will not be
+  possible.
+
+  If you run "make check", an automated test for 'gropdf' will fail.
 
-  As of this writing (2023-02-15), you can find them in the 'fonts'
-  directory of the following archives (choose one).
+  You can obtain the URW base 35 fonts from their GitHub project.  As of
+  this writing (2023-02-15), you can find them in the 'fonts' directory
+  of the following archives (choose one).
 
     https://github.com/ArtifexSoftware/urw-base35-fonts/archive/refs/
       tags/20200910.zip
@@ -426,12 +433,10 @@ AC_DEFUN([GROFF_URW_FONTS_NOTICE], [
     https://github.com/ArtifexSoftware/urw-base35-fonts/releases
 
   By default, groff will look for these fonts in the search path shown
-  by the 'gs -h' command (if available) and in the two directories
-    /usr/share/fonts/type1/gsfonts/
-  and
-    /opt/local/share/fonts/urw-fonts/
-  (these locations are specified in font/devpdf/Foundry.in).  You will
-  need to re-run the 'configure' script after installing these fonts.
+  by the 'gs -h' command (if available) and in several directories
+  specified in font/devpdf/Foundry.in).  You will need to 'make
+  distclean' and re-run the 'configure' script after installing these
+  fonts.
 
   Alternatively, you can pass the option '--with-urw-fonts-dir=DIR'
   to 'configure' to look for them in the directory DIR you specify.


Please comment if you have time before I push.  (No idea when that will be.)


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63824>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/