[bug #62833] [PATCH] tty.cpp: prefer showing data over opinion

[Bjarni Ingi Gislason]

URL:
  <https://savannah.gnu.org/bugs/?62833>

                 Summary: [PATCH] tty.cpp: prefer showing data over opinion
                 Project: GNU troff
               Submitter: bjarniig
               Submitted: Fri 29 Jul 2022 01:16:21 AM UTC
                Category: Device - others/general
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Fri 29 Jul 2022 01:16:21 AM UTC By: Bjarni Ingi Gislason <bjarniig>
>From 7da84c1a23313b3b3dfac0dede125204adf45ca4 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@vortex.is>
Date: Fri, 29 Jul 2022 00:56:54 +0000
Subject: [PATCH] tty.cpp: prefer showing data over opinion

Directory: src/devices/grotty

  Show the data that cause an error message.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@vortex.is>
---
 src/devices/grotty/tty.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/devices/grotty/tty.cpp b/src/devices/grotty/tty.cpp
index 019791667..2b4d25f56 100644
--- a/src/devices/grotty/tty.cpp
+++ b/src/devices/grotty/tty.cpp
@@ -360,7 +360,8 @@ void tty_printer::add_char(output_character c, int w,
 #endif
   int hpos = h / font::hor;
   if (hpos < SHRT_MIN || hpos > SHRT_MAX) {
-    error("character with ridiculous horizontal position discarded");
+    error("character with horizontal position %1 discarded while < %2 or "
+          "> %3", hpos, SHRT_MIN, SHRT_MAX);
     return;
   }
   int vpos;
-- 
2.35.1









    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62833>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/