[bug #62532] libs/libgroff/fontfile.cpp: font::open_file() does unnecessary work sometimes

[G. Branden Robinson]

Update of bug #62532 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 

    _______________________________________________________

Follow-up Comment #2:


commit 02f0e2a0ac699311731aad87620102390f60a629
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon May 30 13:28:33 2022 -0500

    src/libs/libgroff/fontfile.cpp: Refactor function.
    
    * src/libs/libgroff/fontfile.cpp (font::open_file): Refactor.  Move more
      logic, including memory allocation, inside conditional that accepts
      only file names without '/' characters, skipping unnecessary work in
      the alternative.  Annotate use of zero literals as null pointers to
      ease any future migration to ISO C++11.  Add 'const' qualifier to
      variable that doesn't require modification (and which is used in the
      LHS of an equality comparison, so that clumsy operator misuse will
      provoke a compiler warning).
    
    Fixes <https://savannah.gnu.org/bugs/?62532>.  Thanks to Bjarni Ingi
    Gislason for the report.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62532>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/