[bug #62391] [refer] off-by-one line numbering error in invalid input character diagnostics

[G. Branden Robinson]

URL:
  <https://savannah.gnu.org/bugs/?62391>

                 Summary: [refer] off-by-one line numbering error in invalid
input character diagnostics
                 Project: GNU troff
            Submitted by: gbranden
            Submitted on: Mon 02 May 2022 04:17:07 AM UTC
                Category: Preprocessor refer
                Severity: 3 - Normal
              Item Group: None
                  Status: In Progress
                 Privacy: Public
             Assigned to: gbranden
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Seen in groff 1.22.4.

We illustrate with an invalid input character (U+0081, decimal 129) and a
refer(1) command with a missing mandatory argument.

Note the complaint about "line 0".

In groff Git HEAD, the line number won't be reported at all in this case
because of the new diagnostic semantics of line number zero meaning a problem
that isn't specific to an input line.  But it should be.


$ xxd EXPERIMENTS/refer-empty-label.roff
00000000: 2e5c 2220 c281 0a2e 5231 0a6c 6162 656c  .\" ....R1.label
00000010: 0a2e 5232 0a                             ..R2.
$ nl EXPERIMENTS/refer-empty-label.roff 
     1  .\" 
     2  .R1
     3  label
     4  .R2
$ refer EXPERIMENTS/refer-empty-label.roff
.lf 1 EXPERIMENTS/refer-empty-label.roff
refer:EXPERIMENTS/refer-empty-label.roff:0: invalid input character code 129
.\" �
refer:EXPERIMENTS/refer-empty-label.roff:3: missing argument for command
'label'






    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62391>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/