[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #59958] [PATCH] race in Makefile at generation of e.tmac and doc.tm
From: |
G. Branden Robinson |
Subject: |
[bug #59958] [PATCH] race in Makefile at generation of e.tmac and doc.tmac with bigger than -j1 eg. -j4 |
Date: |
Fri, 29 Jan 2021 16:24:15 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 |
Update of bug #59958 (project groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.23.0
_______________________________________________________
Follow-up Comment #4:
commit 362077eeb4abfd0b21416c093d32e4754d975731
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Sat Jan 30 05:23:46 2021 +1100
tmac/tmac.am: Remove unidiomatic for loop.
* tmac/tmac.am ($(TMACSTRIPFILES)):
($(TMACMDOCSTRIPFILES)): Remove unidiomatic for loop which frustrated
parallel make operation.
Thanks to an anonymous contributor for the report and patch.
Fixes <https://savannah.gnu.org/bugs/?59958>.
The bug report characterizes the for loop as a "race", which I don't
think is strictly correct, since the outcome of the work done is not
subject to variation. The body of the for loop is a clobbering shell
redirection operator, so the problem was one of potential pointless
repetition of work in concurrent operation. Good to fix, but not a
cause for alarm.
Problem dates back to 2609cfb727a98809548edfd721c5cb923085b24b, 6
September 2014.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?59958>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/