[bug #51330] preconv fails to detect utf-8 without BOM

[Bertrand Garrigues]

Update of bug #51330 (project groff):

                Severity:              3 - Normal => 4 - Important          
              Item Group:                    None => Incorrect behaviour    
                  Status:               Confirmed => Ready For Test         

    _______________________________________________________

Follow-up Comment #4:

My previous patch was not correct, I don't remember how I tested it, but it
cannot work as I have to rewind the file in function detect_file_encoding. 
I've made more serious tests and now I have 2 patches ready for commit.

- 0001-Add-gnulib-module-fprintf-posix.patch: this adds gnulib's
`fprintf-posix' module to `bootstrap-conf'.  It's somehow difficult for me to
think 'pre-C99'.  I had to add inclusions of 'config.h' in some files because
I had errors like:

./lib/math.h:33:3: error: #error "Please include config.h first."
  #error "Please include config.h first.

- 0002-Use-libchardet-for-preconv.patch: new patch that fixes the previous
one.  I've also fixed the style problem on single-line ELSE clause. As for the
auto-detection we now have a `--with-uchardet' option that works like this
(tested with and without uchardet installed):

. If `yes' is passed and uchardet is not found, configure fails.

. If `no' is passed we don't use uchardet and don't display any warning.

. If `auto' (or any other option) is passed of if --with-uchardet is not
passed, we use uchardet if available, otherwise the build goes on but a
warning is displayed at the end of the configuration phase.

With this patch `typesetting.pdf' is correctly generated.


(file #41186, file #41187)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-Add-gnulib-module-fprintf-posix.patch Size:2 KB
File name: 0002-Use-libchardet-for-preconv.patch Size:9 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51330>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/