[bug #51330] preconv fails to detect utf-8 without BOM

[Werner LEMBERG]

Follow-up Comment #3, bug #51330 (project groff):

Looks good, thanks.  Some nits.

. I suggest to use an auto-detection mode for uchardet, this is, having an
option


--with-uchardet[=auto|no|yes]


where option `auto' is the default.

. In error messages, insert a space after the colon, e.g.

+
fprintf(stderr, "fstat: %s\n", strerror(errno));
                       ^


. The flag `z' you are using in `fprintf' is available only in C99 – AFAIK,
we don't insist on such a `modern' compiler.  So if you really want to use
that flag, you have to add gnulib's `fprintf-posix' module to
`bootstrap-conf'.

. In groff, single-line ELSE clauses in C or C++ code are not surrounded by
braces.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51330>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/