Re: groff: conflict with prototype arg name in getopt.h

[Bruce Lilly]

Werner LEMBERG wrote:
> 
> > DESCRIPTION OF INCORRECT BEHAVIOUR:
> > argument name in getopt_long declaration in src/include/getopt.h
> > conflicts with __argc macro in stdlib.h.  Argument names in
> > prototyped declarations are superfluous; the type suffices.
> 
> I got the following response from Ulrich Drepper:
> 
>   That's crap.  We are not going to remove the parameter names.  This
>   is perfectly valid.
> 
> Not knowing library details intimately, I've looked into my stdlib.h
> file and couldn't found a trace of an `__argc' macro.  And honestly, I
> find it strange that a macro has this name...
> 
> Is this a special UWIN feature?  At least three header files in my
> glibc (argp.h, getopt.h, and ucontext.h) use `__argc' in function
> declarations.
> 
> Nevertheless, I've removed the parameter names in groff-getopt.h --
> maybe you can find a patch to force the use of this header file
> instead?
> 
>     Werner

getopt.h use of identifiers with two leading underscores (i.e. __argc)
is a violation of ANSI/ISO 9899-1990 section 7.1.3 which reserves all
such identifiers.