pipeline.c bug #1

[Bruce Lilly]

                           Groff Bug Report

Please read the PROBLEMS file before sending in a bug report.

Please fill in all fields, even if you think they are not relevant.

Please delete the text in brackets before sending it in.

Please report separate bugs separately.

Send the completed form to address@hidden

GROFF VERSION:
1.17

MACHINE:
Sony PCV-J100

OS:
Microsoft Windows 2000 SP1 with UWIN 2.9
(see http://www.research.att.com/sw/tools/uwin/)

COMPILER:
Microsoft VC++ 6.0 SP5 with UWIN front end

INPUT FILES:
none required

COMMAND LINE:
./configure && make

DESCRIPTION OF INCORRECT BEHAVIOUR:
make fails due to non-prototyped declaration of strerror in pipeline.c.

make output:

cc -I. -I/y/groff/groff-current/src/roff/groff 
-I/y/groff/groff-current/src/include -I/y/groff/groff-current/src/include 
-DHAVE_STDLIB_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DIRENT_H=1 -DHAVE_LIMITS_H=1 
-DHAVE_SYS_DIR_H=1 -DHAVE_STRING_H=1 -DHAVE_STRINGS_H=1 -DHAVE_MATH_H=1 
-DRET_TYPE_SRAND_IS_VOID=1 -DHAVE_SYS_NERR=1 -DHAVE_SYS_ERRLIST=1 
-DHAVE_CC_LIMITS_H=1 -DRETSIGTYPE=void -DHAVE_UNISTD_H=1 -DHAVE_GETPAGESIZE=1 
-DHAVE_FMOD=1 -DHAVE_STRTOL=1 -DHAVE_GETCWD=1 -DHAVE_STRERROR=1 -DHAVE_PUTENV=1 
-DHAVE_RENAME=1 -DHAVE_MKSTEMP=1 -DHAVE_STRCASECMP=1 -DHAVE_STRNCASECMP=1 
-DHAVE_STRDUP=1  -g   -c pipeline.c
/msdev/VC98/include/string.h(132) : error C2375: 'strerror' : redefinition; 
different linkage
        pipeline.c(37) : see declaration of 'strerror'
pipeline.c(131) : error C2065: 'P_WAIT' : undeclared identifier
pipeline.c(131) : warning C4047: 'function' : 'const char *' differs in levels 
of indirection from 'int '
pipeline.c(131) : warning C4024: 'spawnlp' : different types for formal and 
actual parameter 1
pipeline.c(231) : warning C4013: 'spawnvp' undefined; assuming extern returning 
int
make[2]: *** [pipeline.o] Error 1
make[2]: Leaving directory `/Y/groff/groff-current/src/roff/groff'
make[1]: Entering directory `/Y/groff/groff-current'
make[1]: *** [src/roff/groff] Error 2
make[1]: Leaving directory `/Y/groff/groff-current'
make: *** [all] Error 2

SUGGESTED FIX [optional]:
*** src/roff/groff/pipeline.c.orig      Thu Apr 19 22:14:09 2001
--- src/roff/groff/pipeline.c   Thu Apr 19 22:15:40 2001
***************
*** 34,40 ****
  #include <unistd.h>
  #endif
  
! extern char *strerror();
  
  #ifdef _POSIX_VERSION
  
--- 34,40 ----
  #include <unistd.h>
  #endif
  
! #include <string.h>   /* strerror declared here per ANSI/ISO 9899-1990, 
section 7.11.6.2 */
  
  #ifdef _POSIX_VERSION