Re: Typo

[Laurent Lyaudet]

Hello :)

Le sam. 1 juil. 2023 à 13:13, Bruno Haible <bruno@clisp.org> a écrit :
>
> Hello,
>
> > > > I'm reading the documentation and found the following typo:
>
> Thanks for the reports. I've addressed the issues that you found:
> https://git.savannah.gnu.org/gitweb/?p=gperf.git;a=commitdiff;h=2173338a30abe35b16ffb82623206b28149b9a92
Thanks, I still see one, patch below
>
> > > > I have no idea how to submit the equivalent of a pull request with 
> > > > savannah.
>
> Yes, it's a pity that so many people learn about pull requests — a concept 
> that
> 1. assumes a centralized server, 2. is (in the case of GitHub) implemented by
> proprietary software — before they learn about patches [1][2][3] — a concept 
> that
> does not rely on any centralized server. If you have an idea how to improve 
> this,
> please tell us!
>
> Bruno
>
> [1] https://git-scm.com/docs/git-diff
> [2] https://git-scm.com/docs/git-format-patch
> [3] https://git-scm.com/docs/git-am
>
I have read the doc.
I'm using command line git daily at work.
But still I feel overwhelmed when I see this for example:

git format-patch [-k] [(-o|--output-directory) <dir> | --stdout]
  [--no-thread | --thread[=<style>]]
  [(--attach|--inline)[=<boundary>] | --no-attach]
  [-s | --signoff]
  [--signature=<signature> | --no-signature]
  [--signature-file=<file>]
  [-n | --numbered | -N | --no-numbered]
  [--start-number <n>] [--numbered-files]
  [--in-reply-to=<message id>] [--suffix=.<sfx>]
  [--ignore-if-in-upstream] [--always]
  [--cover-from-description=<mode>]
  [--rfc] [--subject-prefix=<subject prefix>]
  [(--reroll-count|-v) <n>]
  [--to=<email>] [--cc=<email>]
  [--[no-]cover-letter] [--quiet]
  [--[no-]encode-email-headers]
  [--no-notes | --notes[=<ref>]]
  [--interdiff=<previous>]
  [--range-diff=<previous> [--creation-factor=<percent>]]
  [--filename-max-length=<n>]
  [--progress]
  [<common diff options>]
  [ <since> | <revision range> ]

I played a little with
git diff -r -p
git diff -r -p --raw
etc.
I have see that there is also a binary patch format, etc.

> If you have an idea how to improve this,
> please tell us!
Sure, just add a file CONTRIBUTING at the root of the repository with:
"If you want to contribute a patch,
please modify the code as you think it should be.
Then commit your changes in one or more commits.
Then send the result of the following command,
for example, if there is only one commit:
git format-patch -1 <commit-sha1>

For more complex cases, see:
https://git-scm.com/docs/git-diff
https://git-scm.com/docs/git-format-patch
https://git-scm.com/docs/git-am

Then send your patch by email at bug-gperf@gnu.org
"

You will certainly see ways to improve this :).
For example, I copy pasted the patches since I'm using gmail webmail.
I do understand it is assumed we use a CLI email client instead of a webmail.
Anyway here are my attempts at both problems:
patch 1
>From c2311dd3d6b6f22467565f7331cdf088eb8d9103 Mon Sep 17 00:00:00 2001
From: Laurent Lyaudet <laurent.lyaudet@gmail.com>
Date: Sat, 1 Jul 2023 15:06:03 +0200
Subject: [PATCH] LL : correction typo "the same size as the number" is O(lg
 number) but "the same as the number" is O(number) :)

---
 doc/gperf.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/gperf.texi b/doc/gperf.texi
index 0ab43c0..5900db9 100644
--- a/doc/gperf.texi
+++ b/doc/gperf.texi
@@ -1338,7 +1338,7 @@ table should decrease the time required for an
unsuccessful search, at
 the expense of extra table space.

 The default value is 1, thus the default maximum associated value is about
-the same size as the number of keywords.  (For efficiency, the maximum
+the same as the number of keywords.  (For efficiency, the maximum
 associated value is always rounded up to a power of 2.)  The actual
 table size may vary somewhat, since this technique is essentially a
 heuristic.
-- 
2.39.2

patch 2
>From 5bc80d9fdc40e5aa66b4292445566b2699d6d679 Mon Sep 17 00:00:00 2001
From: Laurent Lyaudet <laurent.lyaudet@gmail.com>
Date: Sat, 1 Jul 2023 15:18:20 +0200
Subject: [PATCH] LL: attempt at a CONTRIBUTING file to help anyone who does
 not not know where to start.

---
 CONTRIBUTING | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 CONTRIBUTING

diff --git a/CONTRIBUTING b/CONTRIBUTING
new file mode 100644
index 0000000..46fc4bd
--- /dev/null
+++ b/CONTRIBUTING
@@ -0,0 +1,15 @@
+If you want to contribute a patch,
+please modify the code as you think it should be.
+Then commit your changes in one or more commits.
+Then send the result of the following command,
+for example, if there is only one commit:
+git format-patch -1 <commit-sha1>
+
+For more complex cases, see:
+https://git-scm.com/docs/git-diff
+https://git-scm.com/docs/git-format-patch
+https://git-scm.com/docs/git-am
+
+Then send your patch by email at bug-gperf@gnu.org
+Thanks :)
+
-- 
2.39.2

Best regards,
    Laurent Lyaudet

0001-LL-correction-typo-the-same-size-as-the-number-is-O-.patch
Description: Text Data

0001-LL-attempt-at-a-CONTRIBUTING-file-to-help-anyone-who.patch
Description: Text Data