bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: recent changes break gawk compilation


From: Paul Eggert
Subject: Re: recent changes break gawk compilation
Date: Sat, 15 Oct 2022 13:41:09 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 2022-10-15 12:36, Arnold Robbins wrote:
Hi.

In trying to keep gawk up to date with gnulib, I find that there are
several recent changes that break compilation. I'm using Ubuntu 22.04.

In the files dfa.h, localeinfo.h, malloc/dynarray.h, and regex_internal.h,
the include of <stdbool.h> was removed. I don't understand why.

This is because 'bool', 'true', and 'false' are reserved words in C23, so programs cannot assume they are macros and need not include <stdbool.h>. Gnulib is forward-looking here and has largely adopted the C23 style, with compatibility macros in <config.h> for pre-C23 platforms.

To fix this compatibility issue for gawk, please try the attached patches. The first contains the real work. Most of this first patch is simply copying straight from Gnulib; the only changes I made by hand were one-line changes to awk.h (stop including <stdbool.h>) and to configure.ac (use gl_C_BOOL rather than AC_HEADER_STDBOOL).

The second patch affects only autogenerated files; it was automatically generated from the first.

This isn't a complete sync from Gnulib; that is, I didn't worry about Gnulib files unrelated to this issue.

Attachment: 0001-Port-to-current-Gnulib.patch
Description: Text Data

Attachment: 0002-Regenerate.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]