[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" compla
From: |
Robbie Harwood |
Subject: |
Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints |
Date: |
Thu, 09 Dec 2021 12:38:31 -0500 |
Bruno Haible <bruno@clisp.org> writes:
> Paul Eggert replied:
>
>> Every other Gnulib-using project I know takes the third approach.
>
> So, how about adding the third approach to gnulib-tool?
>
> Rationale:
> Gnulib does not want to dictate their preferred GCC flags to coreutils,
> grub, etc.
> And similarly, we don't want coreutils, grub, etc. to dictate the coding
> style in which gnulib is written.
>
> Implementation idea:
> Since 2021-06-10, gnulib-tool already ensures that the Gnulib modules are
> compiled with '-Wno-error'. This code could be extended to add
> '-Wno-sign-compare' and other warning-disabling options.
Given the spirit of the proposal, I'd feel weird commenting on the
chosen warning set, but I do like the idea itself, thanks!
Be well,
--Robbie
signature.asc
Description: PGP signature
- Re: [PATCH v2 05/10] Make gnulib's regcomp not abort(), (continued)
- [PATCH v2 06/10] Make CFLAGS less painful, Robbie Harwood, 2021/12/01
- [PATCH v2 07/10] Fix __argp_fmtstream_point()'s return type and comparisons with it, Robbie Harwood, 2021/12/01
- [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints, Robbie Harwood, 2021/12/01
- Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints, Paul Eggert, 2021/12/01
- Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints, Robbie Harwood, 2021/12/07
- Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints, Paul Eggert, 2021/12/07
- Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints, Bruno Haible, 2021/12/08
- Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints, Jim Meyering, 2021/12/08
- Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints, Paul Eggert, 2021/12/08
- Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints,
Robbie Harwood <=
[PATCH v2 09/10] Paper over a stringop-overflow warning about wide char handling, Robbie Harwood, 2021/12/01
[PATCH v2 10/10] Fixup for -Werror=ignored-qualifiers issues, Robbie Harwood, 2021/12/01
Re: [PATCH v2 00/10] Code hygiene fixes from grub, Bruno Haible, 2021/12/01